Skip to content

Commit 63a24a7

Browse files
authored
Merge pull request #199 from jupp0r/use-expect-eq
Prefer EXPECT_EQ/GT over EXPECT_THAT
2 parents 0ce1e60 + 9399ac8 commit 63a24a7

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

core/tests/family_test.cc

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ TEST(FamilyTest, counter_value) {
3232
auto collected = family.Collect();
3333
ASSERT_GE(collected.size(), 1);
3434
ASSERT_GE(collected[0].metric.size(), 1);
35-
EXPECT_THAT(collected[0].metric.at(0).counter.value, ::testing::Eq(1));
35+
EXPECT_EQ(1, collected[0].metric.at(0).counter.value);
3636
}
3737

3838
TEST(FamilyTest, remove) {
@@ -53,8 +53,7 @@ TEST(FamilyTest, Histogram) {
5353
auto collected = family.Collect();
5454
ASSERT_EQ(collected.size(), 1);
5555
ASSERT_GE(collected[0].metric.size(), 1);
56-
EXPECT_THAT(collected[0].metric.at(0).histogram.sample_count,
57-
::testing::Eq(1));
56+
EXPECT_EQ(1, collected[0].metric.at(0).histogram.sample_count);
5857
}
5958

6059
TEST(FamilyTest, add_twice) {

core/tests/gauge_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ TEST(GaugeTest, set_multiple) {
6161
TEST(GaugeTest, set_to_current_time) {
6262
Gauge gauge;
6363
gauge.SetToCurrentTime();
64-
EXPECT_THAT(gauge.Value(), ::testing::Gt(0.0));
64+
EXPECT_GT(gauge.Value(), 0.0);
6565
}
6666

6767
} // namespace

0 commit comments

Comments
 (0)