Fix IntArray test #32
Open
minrk wants to merge 1 commit into
Open
Conversation
dtype is a constructor arg, not a metadata tag I think it was a coincidence that the early bad_value tests failed with old numpy. They pass as dtype=object with recent numpy
|
np.int has been removed from numpy 1.24. This should be plain 'int' now. |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jan 8, 2023
https://build.opensuse.org/request/show/1056815 by user bnavigator + dimstar_suse - Add python-fix-nptypes.patch gh#jupyter-widgets/traittypes#32 - Clean specfile, no files catachall - Use PEP517 build (forwarded request 1056814 from bnavigator)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dtype is a constructor arg, not a metadata tag
I think it was a coincidence that the early bad_value tests failed with old numpy. They pass as dtype=object with recent numpy. Test is updated to test integer arrays now.
closes #31