async-kernel#697
Conversation
The debugger causes zmq errors somewhere
|
Since the fixes were merged, we should probably rebase this one now. |
JohanMabille
left a comment
JohanMabille
left a comment
There was a problem hiding this comment.
Could you remove the extra empty lines added in this PR?
| #define XEUS_PYTHON_HIDDEN | ||
| #else | ||
| #define XEUS_PYTHON_HIDDEN __attribute__ ((visibility ("hidden"))) | ||
| #endif No newline at end of file |
There was a problem hiding this comment.
Not to be done in this PR, but I think we should refactor the visibility of the symbols:
- make them private by default in the CMakeLists.txt
- define XEUS_PYTHON_API to
__attribute__((visibility("default"))on Unix platforms.
And then remove XPYT_FORCE_PYBIND11_EXPORT and XEUS_PYTHON_HIDDEN
| status = PyConfig_SetBytesArgv(&config, argc, argv); | ||
| if (PyStatus_Exception(status)) { | ||
| std::cerr << "Error:" << status.err_msg << std::endl; | ||
| } |
There was a problem hiding this comment.
I think I confused it with debugging info while cleaning, adding it back now
| namespace xpyt | ||
| { | ||
|
|
||
| XEUS_PYTHON_API XPYT_FORCE_PYBIND11_EXPORT xeus::xkernel::server_builder make_xaserver_factory(py::dict globals); |
There was a problem hiding this comment.
What about renaming this function into make_async_server_factory ? (That would be consistent with xasync_runner).
|
Is https://github.com/jupyter-xeus/xeus-python-shell/pull/29/changes ready to review? |
@JohanMabille yes |
JohanMabille
left a comment
JohanMabille
left a comment
There was a problem hiding this comment.
LGTM when the CI jobs use xeus-python-shell from conda-forge.
| environment-file: environment-dev.yml | ||
|
|
||
| - name: Install xeus-python-shell from GitHub | ||
| run: pip install git+https://github.com/DerThorsten/xeus-python-shell.git@akernel |
There was a problem hiding this comment.
I've just merged the xeus-python-shell-feedstock, should be available soon
5 participants
toplevel awaits /async kernel: