Skip to content

ci(cypress): Fix ACI test currency and add Interac test case#11657

Open
venkatakarthikm-maker wants to merge 3 commits into
mainfrom
aci-fix
Open

ci(cypress): Fix ACI test currency and add Interac test case#11657
venkatakarthikm-maker wants to merge 3 commits into
mainfrom
aci-fix

Conversation

@venkatakarthikm-maker
Copy link
Copy Markdown
Contributor

@venkatakarthikm-maker venkatakarthikm-maker commented Mar 31, 2026

  • Change currency from EUR to USD in ACI connector tests
    To solve cross currency mandate issue as ACI doesn't support it.
  • Add Interac bank redirect payment method test for CAD currency

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

- Change currency from EUR to USD in ACI connector tests
- Add Interac bank redirect payment method test for CAD currency
@venkatakarthikm-maker venkatakarthikm-maker self-assigned this Mar 31, 2026
@venkatakarthikm-maker venkatakarthikm-maker requested a review from a team as a code owner March 31, 2026 12:59
@venkatakarthikm-maker venkatakarthikm-maker added A-CI-CD Area: Continuous Integration/Deployment S-test-ready Status: This PR is ready for cypress-tests labels Mar 31, 2026
@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com Bot commented Mar 31, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  cypress-tests/cypress/e2e/configs/Payment/Aci.js  6% smaller

@venkatakarthikm-maker venkatakarthikm-maker removed the S-test-ready Status: This PR is ready for cypress-tests label Mar 31, 2026
@venkatakarthikm-maker venkatakarthikm-maker added the S-test-ready Status: This PR is ready for cypress-tests label Apr 8, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@a62b6da). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11657   +/-   ##
=======================================
  Coverage        ?        0           
=======================================
  Files           ?        0           
  Lines           ?        0           
  Branches        ?        0           
=======================================
  Hits            ?        0           
  Misses          ?        0           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI-CD Area: Continuous Integration/Deployment S-test-ready Status: This PR is ready for cypress-tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants