refactor(router): remove mandate validation function#11664
Open
AkshayaFoiger wants to merge 23 commits into
Open
refactor(router): remove mandate validation function#11664AkshayaFoiger wants to merge 23 commits into
AkshayaFoiger wants to merge 23 commits into
Conversation
4 tasks
deepanshu-iiitu
previously approved these changes
Apr 7, 2026
sai-harsha-vardhan
previously approved these changes
Apr 8, 2026
Contributor
sai-harsha-vardhan
left a comment
There was a problem hiding this comment.
How have we verified if the behaviour is same, and all the env values are accurate based on trait definitions? @AkshayaFoiger
0108716
Contributor
Author
Added test case analysis to the PR description. This verifies, the behavior doesn't change |
Contributor
Author
deepanshu-iiitu
previously approved these changes
Apr 8, 2026
sai-harsha-vardhan
previously approved these changes
Apr 9, 2026
Contributor
Author
|
@copilot Give a summary of this change |
deepanshu-iiitu
previously approved these changes
Apr 27, 2026
ddab07d
deepanshu-iiitu
previously approved these changes
Apr 30, 2026
sai-harsha-vardhan
previously approved these changes
May 5, 2026
a144590
deepanshu-iiitu
approved these changes
May 6, 2026
sai-harsha-vardhan
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Type of Change
Description
Remove mandate_validation() from ConnectorValidations. As this check is already done from data fetched from .toml files and core has step-down logics accordingly
How did you test it?
Create a payment with setupfuture_usage = off_session - for a payment method that don't support mandate
If the payment_method is implemented but mandate is not implemented for the payment_method - It will not throw a not supported error
Response
Mandate Payments via any connector
Response
MIT
Response
Test Worldpayvantiv NTID + Wallet flow
Response
Stripe cypress test ran along with the PR - confirms the changes for mandates
Checklist
cargo +nightly fmt --allcargo clippy