Skip to content

Feat(rnpsw) add commit title check#226

Open
Jokotoye18 wants to merge 6 commits into
just1and0:mainfrom
Jokotoye18:feat(RNPSW)-add-commit-title-check
Open

Feat(rnpsw) add commit title check#226
Jokotoye18 wants to merge 6 commits into
just1and0:mainfrom
Jokotoye18:feat(RNPSW)-add-commit-title-check

Conversation

@Jokotoye18

@Jokotoye18 Jokotoye18 commented Sep 1, 2025

Copy link
Copy Markdown

Description

Currently when contributors raise PRs, they usually forget to use the correct commit title convension and this breaks CI, and features don't get published to npm.

We need to add a pre check when users try to make a commit. And show meaningful warnings ⚠️

Issue URL

#206

Before and After

Add Image/video/gifs of changes

Before After
Visual: Visual:
Functionality: Functionality:

@Jokotoye18 Jokotoye18 marked this pull request as draft September 1, 2025 16:13
@just1and0

just1and0 commented Sep 1, 2025

Copy link
Copy Markdown
Owner

@Jokotoye18 thanks a mill for working on this. This will ensure folks don't open PRs without the desired commit titles and stop a lot of deployment and release issues moving forward!

I will review this right away!

@Jokotoye18 Domt forget to remove from draft.

@Jokotoye18 Jokotoye18 marked this pull request as ready for review September 5, 2025 12:11
@Jokotoye18

Copy link
Copy Markdown
Author

@Jokotoye18 thanks a mill for working on this. This will ensure folks don't open PRs without the desired commit titles and stop a lot of deployment and release issues moving forward!

I will review this right away!

@Jokotoye18 Domt forget to remove from draft.

This is now ready for review @just1and0

@just1and0

Copy link
Copy Markdown
Owner

@Jokotoye18 please can you update the pr description.

Comment thread package.json
]
} No newline at end of file
],
"packageManager": "yarn@1.22.22"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jokotoye18 Remember we’re also bumping this to yarn@4.5.3 in your other PR…hope that won’t cause any conflicts?

https://github.com/just1and0/React-Native-Paystack-WebView/pull/222/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

@just1and0

Copy link
Copy Markdown
Owner

@Jokotoye18, please can you resolve the conflict and attend to any pending conversations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants