Skip to content

fix(RNPSW): respect safe areas and update deps#231

Open
collinsedim wants to merge 2 commits into
just1and0:mainfrom
collinsedim:fix/safe-area-and-deps
Open

fix(RNPSW): respect safe areas and update deps#231
collinsedim wants to merge 2 commits into
just1and0:mainfrom
collinsedim:fix/safe-area-and-deps

Conversation

@collinsedim

Copy link
Copy Markdown

Description

  • Wrap the pay modal in SafeAreaView from react-native-safe-area-context so content clears the status bar/notches (development/PaystackProvider.tsx:1-80).
  • Remove deprecated react-native SafeAreaView import and keep modal open/close logic the same (development/PaystackProvider.tsx:1-80).
  • Add react-native-safe-area-context dependency and bump React, React Native, webview, validator, TypeScript, Babel, ESLint, etc. to current versions (package.json:35-64).
  • Small formatting tidy-up of provider component (same file).

Reviewer

Issue URL

None

Before and After

Add Image/video/gifs of changes

Before After
Visual: Visual:
Functionality: Functionality:

@eminisolomon

Copy link
Copy Markdown

@just1and0 please approve this

@just1and0 just1and0 self-requested a review November 21, 2025 08:04

@just1and0 just1and0 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@collinsedim Thanks for making these changes. Just a small nit: the entire file was reformatted, which makes it hard to track the actual updates. Could you revert the formatting and only apply the changes related to your update?

Once that’s done, please request a review and I’ll take a look ASAP.

@collinsedim

Copy link
Copy Markdown
Author

@just1and0 yeah, sorry about that. I have auto-formatting turned on in my editor. I just made the requested change.

@mosoakinyemi

mosoakinyemi commented May 31, 2026

Copy link
Copy Markdown
Collaborator

Thanks for your contribution @collinsedim!
Kindly rebase your changes and resolve the conflicts

@just1and0

just1and0 commented Jun 9, 2026

Copy link
Copy Markdown
Owner

@collinsedim, please can you fix the conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants