Skip to content

Implements the changes to allow 'ts -s 0', to gracefully end current active jobs and not start any new jobs #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidmacmillan wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Implements the changes to allow 'ts -s 0', to gracefully end current active jobs and not start any new jobs #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd40b23
Update main.c
davidmacmillan Apr 25, 2025
1c19faf
Update jobs.c
davidmacmillan Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jobs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1585,7 +1585,7 @@ void s_wait_running_job(int s, int jobid) {
}

void s_set_max_slots(int new_max_slots) {
if (new_max_slots > 0)
if (new_max_slots >= 0) /* -S 0 lets active jobs end without starting new ones. */
max_slots = new_max_slots;
else
warning("Received new_max_slots=%i", new_max_slots);
Expand Down
4 changes: 2 additions & 2 deletions main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,8 +290,8 @@ void parse_opts(int argc, char **argv) {
case 'S':
command_line.request = c_SET_MAX_SLOTS;
command_line.max_slots = atoi(optarg);
if (command_line.max_slots < 1) {
fprintf(stderr, "You should set at minimum 1 slot.\n");
if (command_line.max_slots < 0) { /* -S 0 lets active jobs end without starting new ones. */
fprintf(stderr, "You should set to 0 or more slots.\n"); /* was: You should set at minimum 1 slot.\n */
exit(-1);
}
break;
Expand Down