Added support for Redirect binding for SSO.#59
Open
datb-com wants to merge 23 commits into
Open
Conversation
SpectralDuck
reviewed
Jun 3, 2020
…ypted assertions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When our client switched between versions of their IDP they lost support for POST and the vendor of the IDP suggested we use Redirect for SSO.
I've implemented the bits specified in the spec and it does now work for Redirect with the IDP that we were having issues with. I'm not an expert in this code and so somebody definitely needs to confirm my implementation.