code quality: replace unnecessary is_object() with property_exists() in wpmu_validate_blog_signup()

justlevine · justlevine · commit 1cc6b8ee2b50 · 2025-06-13T00:50:52.000+03:00
diff --git a/src/wp-includes/ms-functions.php b/src/wp-includes/ms-functions.php
@@ -730,7 +730,7 @@ function wpmu_validate_blog_signup( $blogname, $blog_title, $user = '' ) {
 	 * unless it's the user's own username.
 	 */
 	if ( username_exists( $blogname ) ) {
-		if ( ! is_object( $user ) || ( is_object( $user ) && $user->user_login !== $blogname ) ) {
+		if ( ! is_object( $user ) || ( property_exists( $user, 'user_login' ) && $user->user_login !== $blogname ) ) {
 			$errors->add( 'blogname', __( 'Sorry, that site is reserved!' ) );
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -730,7 +730,7 @@ function wpmu_validate_blog_signup( $blogname, $blog_title, $user = '' ) {`
`730`	`730`	`* unless it's the user's own username.`
`731`	`731`	`*/`
`732`	`732`	`if ( username_exists( $blogname ) ) {`
`733`		`- if ( ! is_object( $user ) \|\| ( is_object( $user ) && $user->user_login !== $blogname ) ) {`
	`733`	`+ if ( ! is_object( $user ) \|\| ( property_exists( $user, 'user_login' ) && $user->user_login !== $blogname ) ) {`
`734`	`734`	`$errors->add( 'blogname', __( 'Sorry, that site is reserved!' ) );`
`735`	`735`	`}`
`736`	`736`	`}`