code quality: remove always-true check from wp_read_image_metadata()

justlevine · justlevine · commit c608cc8609a9 · 2025-06-13T00:52:07.000+03:00
diff --git a/src/wp-admin/includes/image.php b/src/wp-admin/includes/image.php
@@ -967,7 +967,7 @@ function wp_read_image_metadata( $file ) {
 			}
 
 			// If both user comments and description are present.
-			if ( empty( $meta['caption'] ) && $exif_description && $exif_usercomment ) {
+			if ( empty( $meta['caption'] ) && $exif_usercomment ) {
 				if ( ! empty( $meta['title'] ) && $exif_description === $meta['title'] ) {
 					$caption = $exif_usercomment;
 				} else {

Original file line number	Diff line number	Diff line change
`@@ -967,7 +967,7 @@ function wp_read_image_metadata( $file ) {`
`967`	`967`	`}`
`968`	`968`
`969`	`969`	`// If both user comments and description are present.`
`970`		`- if ( empty( $meta['caption'] ) && $exif_description && $exif_usercomment ) {`
	`970`	`+ if ( empty( $meta['caption'] ) && $exif_usercomment ) {`
`971`	`971`	`if ( ! empty( $meta['title'] ) && $exif_description === $meta['title'] ) {`
`972`	`972`	`$caption = $exif_usercomment;`
`973`	`973`	`} else {`