Tracking: PHPStan Remediations#1
Open
justlevine wants to merge 35 commits intofeat/phpstanfrom
Open
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
justlevine
force-pushed
the
chore/phpstan/level-0
branch
from
ba1b7ed to
6c9e72b
Compare
justlevine
force-pushed
the
feat/phpstan
branch
2 times, most recently
from
6695813 to
947a5fe
Compare
justlevine
force-pushed
the
chore/phpstan/level-0
branch
from
682af29 to
7a29cd9
Compare
justlevine
force-pushed
the
chore/phpstan/level-0
branch
3 times, most recently
from
2ea3189 to
0802cca
Compare
justlevine
force-pushed
the
chore/phpstan/level-0
branch
from
f69ef87 to
c575bbb
Compare
justlevine
force-pushed
the
chore/phpstan/level-0
branch
2 times, most recently
from
e4cbd2f to
3277cd6
Compare
justlevine
force-pushed
the
chore/phpstan/level-0
branch
from
3277cd6 to
7a54a48
Compare
justlevine
force-pushed
the
feat/phpstan
branch
2 times, most recently
from
47d4cd2 to
f1f214d
Compare
justlevine
force-pushed
the
chore/phpstan/level-0
branch
2 times, most recently
from
bec2a94 to
bee227b
Compare
justlevine
force-pushed
the
chore/phpstan/level-0
branch
from
bee227b to
738b3b5
Compare
justlevine
force-pushed
the
chore/phpstan/level-0
branch
from
738b3b5 to
03e7452
Compare
justlevine
force-pushed
the
chore/phpstan/level-0
branch
from
a199310 to
80d3039
Compare
justlevine
force-pushed
the
feat/phpstan
branch
from
9516015 to
12675ea
Compare
justlevine
force-pushed
the
feat/phpstan
branch
from
12675ea to
6e2aa00
Compare
…twork/sites.php`
….php, WP_Posts_List_Table, and WP_Screen
It's the entrypoint into this codeblock two lines above
…gs_Registry::register()
remove_query_arg() only takes `string|string[]`. Added a comment because it took me 5 minutes to understand _why_ we were using
justlevine
force-pushed
the
chore/phpstan/level-0
branch
from
80d3039 to
edabf22
Compare
…_REST_Attachments_Controller::edit_media_item() see: WordPress@117f23f#r168784907
justlevine
pushed a commit
that referenced
this pull request
Mar 16, 2026
…om `previous_posts()`. The `esc_url()` function expects to a string for `$url` parameter. There is no input validation within that function. The function contains a `ltrim()` which also expects a string. Passing `null` to this parameter results in `Deprecated: ltrim(): Passing null to parameter #1 ($string) of type string is deprecated` notice on PHP 8.1+. Tracing the stack back, a `null` is being passed to it within `previous_posts()` when `get_previous_posts_page_link()` returns `null` (it can return a string or `null`). On PHP 7.0 to PHP 8.x, an empty string is returned from `esc_url()` when `null` is passed to it. The change in this changeset avoids the deprecation notice by not invoking `esc_url()` when `get_previous_posts_page_link()` returns `null` and instead sets the `$output` to an empty string, thus maintaining the same behavior as before (minus the deprecation notice). Adds a test to validate an empty string is returned and the absence of the deprecation (when running on PHP 8.1+). Follow-up to [9632], [11383], [56740]. Props dd32, alexodiy. Fixes #64864. git-svn-id: https://develop.svn.wordpress.org/trunk@62034 602fd350-edb4-49c9-b593-d223f7449a82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remediating PHPStan fixes in-situ.
Individual fixes are cherry-picked into separate PRs onto
trunk, and then removed from here when this is periodically rebased.Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.