Tracking: PHPStan Remediations#1

Open

justlevine wants to merge 35 commits intofeat/phpstanfrom

chore/phpstan/level-0

Commits on Oct 24, 2025

[PHPStan]: Apply `@phpstan-` typehints
justlevine
committed
[PHPStan]: restore scanning WP_HTML_Processor with PHPStan
justlevine
committed
[PHPStan]: Add more typehints
justlevine
committed
chore: improve doctypes /type safety for `WP_Screen` properties
justlevine
committed
fix: ensure wp_create_category() returns `int`
justlevine
committed
code quality: remove unnecessary empty() check in wp_insert_user()
justlevine
committed
fix: define `$schema` in `WP_REST_Attachments_Controller::update_item()`
justlevine
committed
chore: remove needly `empty( )` check in `wpdb::set_sql_mode()`
justlevine
committed
fix: cast `base_convert()` to `int` before binaryOp
justlevine
committed
chore: cast headers to string in `WP_REST_Comments_Controller::get_items()`
justlevine
committed
docs: fix return type for WP_HTML_Decoder::read_character_reference()
justlevine
committed
docs: fix return type for WP_Speculation_Rules::jsonSerialize to array<string,list>
justlevine
committed
docs: Fix misc `@var` tags on nullable class props
justlevine
committed
code quality: explicitly return `null` when documented
justlevine
committed
code quality: remove unreachable `break;` from `allsites` case in `network/sites.php`
justlevine
committed
code quality: add explicit `: void` to method signatures in wp-signup.php, WP_Posts_List_Table, and WP_Screen
justlevine
committed
code quality: remove needless $cpage checks from `get_comment_link()`
justlevine
committed
code quality: remove always-true ternary from _wp_menu_object()
justlevine
committed
fix: correctly check for trimmed value in wp_get_layout_style()
justlevine
committed
code quality: remove unreachable _doing_it_wrong from WP_Block_Bindings_Registry::register()
justlevine
committed
chore: remove always-true if() from WP_Interactvity_API::config()
justlevine
committed
code quality: fix usage of `remove_query_arg()` in wp-activate.php
justlevine
committed
code quality: explicitly return null instead of coercing `void`
justlevine
committed
code quality: remove always-true negated bools
justlevine
committed
chore: fix invalid argument types in `ms-site.php`
justlevine
committed
chore: fix invalid argument types in `taxonomy.php`
justlevine
committed
phpstan: regenerate baselines
justlevine
committed
phpstan: annotations
justlevine
committed
phpstan: update excludePaths
justlevine
committed
fix: cast `$new_attachment_id` to array before `wp_slash()` ing in WP_REST_Attachments_Controller::edit_media_item()
justlevine
committed
chore: regenerate baselines
justlevine
committed