Skip to content

Commit 5999e84

Browse files
committed
ci: restore Ninja output paths in build workflow (v6.0.0.6)
1 parent 6d95eb2 commit 5999e84

2 files changed

Lines changed: 8 additions & 9 deletions

File tree

.github/workflows/build-release.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,8 @@ jobs:
6161
run: |
6262
$archUpper = if ("${{ matrix.platform }}" -eq "x64") { "X64" } else { "ARM64" }
6363
64-
# Path for CMake build artifact
65-
$exePath = "out/build/${{ matrix.preset }}/Release/QuickView.exe"
64+
# Path for CMake build artifact (Ninja puts it in root)
65+
$exePath = "out/build/${{ matrix.preset }}/QuickView.exe"
6666
if (-not (Test-Path $exePath)) { Write-Error "EXE not found at $exePath"; exit 1 }
6767
6868
# Extract version
@@ -89,10 +89,9 @@ jobs:
8989
$tag = "${{ env.DETECTED_TAG }}"
9090
$version = $tag.TrimStart('v')
9191
92-
# Update Inno Setup to use CMake output path
93-
# Note: We need to pass the EXE path to ISCC or update .iss
92+
# Invoke ISCC with correct ExePath
9493
$outputName = "QuickView_Installer_${tag}_${archUpper}"
95-
& "C:\Program Files (x86)\Inno Setup 6\ISCC.exe" /DMyAppVersion=$version /DAppArch=$arch /DOutputName=$outputName /DExePath="out/build/${{ matrix.preset }}/Release/QuickView.exe" /O"Release\dist" installer\QuickView.iss
94+
& "C:\Program Files (x86)\Inno Setup 6\ISCC.exe" /DMyAppVersion=$version /DAppArch=$arch /DOutputName=$outputName /DExePath="out/build/${{ matrix.preset }}/QuickView.exe" /O"Release\dist" installer\QuickView.iss
9695
9796
- name: Upload Build Artifacts
9897
uses: actions/upload-artifact@v4

QuickView/QuickView.rc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010

1111
// Version Information - This sets the display name in Windows
1212
VS_VERSION_INFO VERSIONINFO
13-
FILEVERSION 6,0,0,5
14-
PRODUCTVERSION 6,0,0,5
13+
FILEVERSION 6,0,0,6
14+
PRODUCTVERSION 6,0,0,6
1515
FILEFLAGSMASK 0x3fL
1616
FILEFLAGS 0x0L
1717
FILEOS VOS_NT_WINDOWS32
@@ -24,11 +24,11 @@ BEGIN
2424
BEGIN
2525
VALUE "CompanyName", "QuickView"
2626
VALUE "FileDescription", "QuickView"
27-
VALUE "FileVersion", "6.0.0.5"
27+
VALUE "FileVersion", "6.0.0.6"
2828
VALUE "InternalName", "QuickView"
2929
VALUE "OriginalFilename", "QuickView.exe"
3030
VALUE "ProductName", "QuickView"
31-
VALUE "ProductVersion", "6.0.0.5"
31+
VALUE "ProductVersion", "6.0.0.6"
3232
END
3333
END
3434
BLOCK "VarFileInfo"

0 commit comments

Comments
 (0)