Fix broken LBP visualization

Author: juzzlin

CHANGELOG

@@ -13,6 +13,8 @@ Bug fixes:
 
 * Fix velocity interpolation not undo'ed
 
+* Fix broken LBP visualization
+
 Other:
 
 * Busy wait in PlayerWorker for higher precision

src/application/models/note_column_model.cpp

@@ -181,7 +181,9 @@ void NoteColumnModel::notifyDataChanged(int startLine, int endLine, const QList<
 
 void NoteColumnModel::updateIndexHighlights()
 {
-    notifyDataChanged(0, rowCount() - 1, { static_cast<int>(DataRole::Color), static_cast<int>(DataRole::Border) });
+    if (!m_lines.empty()) {
+        notifyDataChanged(0, static_cast<int>(m_lines.size()) - 1, { static_cast<int>(DataRole::Color), static_cast<int>(DataRole::Border) });
+    }
 }
 
 void NoteColumnModel::updateIndexHighlightAtPosition(quint64 line)

src/unit_tests/note_column_model_test/note_column_model_test.cpp

@@ -106,6 +106,37 @@ void NoteColumnModelTest::test_setLineFocused_shouldUpdateData()
     QCOMPARE(model.data(idx, static_cast<int>(NoteColumnModel::DataRole::LineColumn)).toInt(), 1);
 }
 
+void NoteColumnModelTest::test_updateIndexHighlights_shouldEmitDataChangedWithCorrectRange()
+{
+    const auto automationService { std::make_shared<AutomationService>() };
+    const auto selectionService { std::make_shared<SelectionService>() };
+    const auto settingsService { std::make_shared<SettingsService>() };
+    const auto editorService { std::make_shared<EditorService>(selectionService, settingsService) };
+    const auto utilService { std::make_shared<UtilService>() };
+    const auto helper { std::make_shared<NoteColumnLineContainerHelper>(automationService, editorService, selectionService, utilService) };
+
+    NoteColumnModel model { { 0, 0, 0 }, editorService, helper, settingsService };
+
+    const int lineCount = 10;
+    NoteColumnModel::LineList lines;
+    for (int i = 0; i < lineCount; ++i) {
+        lines.push_back(std::make_shared<Line>(static_cast<size_t>(i)));
+    }
+    model.setColumnData(lines);
+
+    QSignalSpy spy { &model, &NoteColumnModel::dataChanged };
+    model.updateIndexHighlights();
+
+    QCOMPARE(spy.count(), 1);
+    const auto arguments = spy.takeFirst();
+    const auto topLeft = arguments.at(0).value<QModelIndex>();
+    const auto bottomRight = arguments.at(1).value<QModelIndex>();
+
+    const int barLine = static_cast<int>(editorService->positionBarLine());
+    QCOMPARE(topLeft.row(), barLine);
+    QCOMPARE(bottomRight.row(), barLine + lineCount - 1);
+}
+
 } // namespace noteahead
 
 QTEST_GUILESS_MAIN(noteahead::NoteColumnModelTest)

src/unit_tests/note_column_model_test/note_column_model_test.hpp

@@ -31,6 +31,7 @@ private slots:
     void test_rowCount_shouldReturnCorrectValue();
     void test_data_shouldReturnCorrectValues();
     void test_setLineFocused_shouldUpdateData();
+    void test_updateIndexHighlights_shouldEmitDataChangedWithCorrectRange();
 };
 
 } // namespace noteahead