feat: new valuetype SheetRow

Replaces `Collection<text>` for interpreting tables.

Author: jrentlez

libs/execution/src/lib/types/value-types/internal-representation-parsing.ts

@@ -147,4 +147,8 @@ class InternalRepresentationParserVisitor extends ValueTypeVisitor<
       `Cannot parse valuetype definitions into internal values`,
     );
   }
+
+  override visitSheetRow(): InvalidValue {
+    return new InvalidValue(`Cannot parse sheet rows into internal values`);
+  }
 }

libs/execution/src/lib/types/value-types/value-representation-validity.ts

@@ -6,6 +6,7 @@
 import { strict as assert } from 'assert';
 
 import {
+  type SheetRowValueType,
   type AtomicValueType,
   type BooleanValuetype,
   type CellRangeValuetype,
@@ -130,6 +131,10 @@ class ValueRepresentationValidityVisitor extends ValueTypeVisitor<boolean> {
     return this.isValidForPrimitiveValuetype(valueType);
   }
 
+  override visitSheetRow(valueType: SheetRowValueType): boolean {
+    return this.isValidForPrimitiveValuetype(valueType);
+  }
+
   override visitTransform(valueType: TransformValuetype): boolean {
     return this.isValidForPrimitiveValuetype(valueType);
   }

libs/execution/src/lib/types/value-types/visitors/sql-column-type-visitor.ts

@@ -76,6 +76,12 @@ export class SQLColumnTypeVisitor extends ValueTypeVisitor<string> {
     );
   }
 
+  override visitSheetRow(): string {
+    throw new Error(
+      'No visit implementation given for sheet rows. Cannot be the type of a column.',
+    );
+  }
+
   override visitTransform(): string {
     throw new Error(
       'No visit implementation given for transforms. Cannot be the type of a column.',

libs/execution/src/lib/types/value-types/visitors/sql-value-representation-visitor.ts

@@ -130,6 +130,14 @@ export class SQLValueRepresentationVisitor extends ValueTypeVisitor<
     );
   }
 
+  override visitSheetRow(): (
+    value: InternalValidValueRepresentation | InternalErrorValueRepresentation,
+  ) => string {
+    throw new Error(
+      'No visit implementation given for sheet row. Cannot be the type of a column.',
+    );
+  }
+
   override visitTransform(): (
     value: InternalValidValueRepresentation | InternalErrorValueRepresentation,
   ) => string {

libs/language-server/src/lib/ast/expressions/type-computers/dot-operator-type-computer.ts

@@ -7,7 +7,6 @@ import { type BinaryExpression } from '../../generated/ast';
 import {
   type ValueType,
   type ValueTypeProvider,
-  isCollectionValueType,
 } from '../../wrappers/value-type';
 import { type BinaryOperatorTypeComputer } from '../operator-type-computer';
 
@@ -20,12 +19,7 @@ export class DotOperatorTypeComputer implements BinaryOperatorTypeComputer {
     expression: BinaryExpression,
     context: ValidationContext | undefined,
   ): ValueType | undefined {
-    if (
-      !isCollectionValueType(
-        leftOperandType,
-        this.valueTypeProvider.Primitives.Text,
-      )
-    ) {
+    if (!leftOperandType.equals(this.valueTypeProvider.Primitives.SheetRow)) {
       context?.accept(
         'error',
         `Operator does not support type ${leftOperandType.getName()}`,

libs/language-server/src/lib/ast/wrappers/value-type/primitive/collection/abstract-collection-value-type.ts

@@ -14,8 +14,4 @@ export abstract class AbstractCollectionValueType<
   override isAllowedAsRuntimeParameter(): boolean {
     return false;
   }
-
-  override isReferenceableByUser(): boolean {
-    return true;
-  }
 }

libs/language-server/src/lib/ast/wrappers/value-type/primitive/index.ts

@@ -22,6 +22,7 @@ export { type TextValuetype } from './text-value-type';
 export { type TransformValuetype } from './transform-value-type';
 export { type ValuetypeAssignmentValuetype } from './value-type-assignment-value-type';
 export { type ValuetypeDefinitionValuetype } from './value-type-definition-value-type';
+export { type SheetRowValueType } from './sheetrow-value-type';
 
 export {
   ValueTypeProvider,

libs/language-server/src/lib/ast/wrappers/value-type/primitive/primitive-value-type-provider.ts

@@ -16,6 +16,7 @@ import { type PrimitiveValueType } from './primitive-value-type';
 import { RegexValuetype } from './regex-value-type';
 import { TextValuetype } from './text-value-type';
 import { TransformValuetype } from './transform-value-type';
+import { SheetRowValueType } from './sheetrow-value-type';
 import { ValuetypeAssignmentValuetype } from './value-type-assignment-value-type';
 import { ValuetypeDefinitionValuetype } from './value-type-definition-value-type';
 
@@ -48,6 +49,8 @@ export class PrimitiveValueTypeProvider {
 
   Transform = new TransformValuetype();
 
+  SheetRow = new SheetRowValueType();
+
   getAll(): PrimitiveValueType[] {
     return [
       this.Boolean,
@@ -60,6 +63,7 @@ export class PrimitiveValueTypeProvider {
       this.ValuetypeAssignment,
       this.ValuetypeDefinition,
       this.Transform,
+      this.SheetRow,
     ];
   }
 }

libs/language-server/src/lib/ast/wrappers/value-type/primitive/sheetrow-value-type.ts

@@ -0,0 +1,34 @@
+// SPDX-FileCopyrightText: 2023 Friedrich-Alexander-Universitat Erlangen-Nurnberg
+//
+// SPDX-License-Identifier: AGPL-3.0-only
+
+import { PrimitiveValueType } from './primitive-value-type';
+import { type ValueTypeVisitor } from '../value-type';
+import { type InternalValidValueRepresentation } from '../../../expressions';
+
+export class SheetRowValueType extends PrimitiveValueType<string[]> {
+  acceptVisitor<R>(visitor: ValueTypeVisitor<R>): R {
+    return visitor.visitSheetRow(this);
+  }
+
+  override isAllowedAsRuntimeParameter(): false {
+    return false;
+  }
+
+  override getName(): 'SheetRow' {
+    return 'SheetRow';
+  }
+
+  override isInternalValidValueRepresentation(
+    operandValue: InternalValidValueRepresentation,
+  ): operandValue is string[] {
+    return (
+      Array.isArray(operandValue) &&
+      operandValue.every((element) => typeof element === 'string')
+    );
+  }
+
+  override isReferenceableByUser(): true {
+    return true;
+  }
+}

libs/language-server/src/lib/ast/wrappers/value-type/value-type.ts

@@ -20,6 +20,7 @@ import {
   type RegexValuetype,
   type TextValuetype,
   type TransformValuetype,
+  type SheetRowValueType,
   type ValuetypeAssignmentValuetype,
 } from './primitive';
 
@@ -93,4 +94,6 @@ export abstract class ValueTypeVisitor<R = unknown> {
   abstract visitTransform(valueType: TransformValuetype): R;
 
   abstract visitAtomicValueType(valueType: AtomicValueType): R;
+
+  abstract visitSheetRow(valueType: SheetRowValueType): R;
 }