feat!(io): filename uses id instead of name

Signed-off-by: Juan Rubio <jcrubio@gmail.com>

Author: jzer7

Makefile

@@ -111,8 +111,8 @@ test-e2e: ## 🧪 Run end-to-end tests
 	rm -f "playlists/Greatest Film Themes of All Time.yaml"
 	mkdir -p playlists
 	uv run listify download --id "6LFObuU0EvpaQLj1iueTHO"
-	test -f "playlists/Greatest Film Themes of All Time.yaml"
-	yq .owner_id "playlists/Greatest Film Themes of All Time.yaml" | grep "bbcmusicmagazine" || (echo "Owner ID does not match expected value" && exit 1)
+	test -f "playlists/playlist_6LFObuU0EvpaQLj1iueTHO.yaml"
+	yq .owner_id "playlists/playlist_6LFObuU0EvpaQLj1iueTHO.yaml" | grep "bbcmusicmagazine" || (echo "Owner ID does not match expected value" && exit 1)
 
 # ----------------------------------------------------------
 # Build

src/spotify_lists/io.py

@@ -6,14 +6,20 @@
 
 
 def save_playlist(playlist: Playlist, directory: Path) -> None:
-    """Saves a playlist to a YAML file in the specified directory."""
+    """Saves a playlist as a YAML file.
+
+    The filename uses the format "playlist_{playlist_id}.yaml".
+    The function ensures the directory exists and overwrites
+    any existing file with the same name.
+
+    Returns:
+        None
+    """
     directory.mkdir(parents=True, exist_ok=True)
 
-    # Sanitize filename
-    safe_name = "".join([c for c in playlist.name if c.isalpha() or c.isdigit() or c == " "]).strip()
-    if not safe_name:
-        safe_name = f"playlist_{playlist.id}"
-    filename = directory / f"{safe_name}.yaml"
+    # Name is "playlist_{id}.yaml"
+    filename = f"playlist_{playlist.id}.yaml"
+    filepath = directory / filename
 
-    with open(filename, "w", encoding="utf-8") as f:
+    with open(filepath, "w", encoding="utf-8") as f:
         yaml.dump(playlist.to_dict(), f, sort_keys=False, allow_unicode=True)

tests/test_io.py

@@ -0,0 +1,78 @@
+"""Unit tests for io.py."""
+
+from pathlib import Path
+
+import pytest
+import yaml
+
+from spotify_lists.io import save_playlist
+from spotify_lists.models import Playlist, Track
+
+# ---------------------------------------------------------------------------
+# Fixtures
+# ---------------------------------------------------------------------------
+
+
+@pytest.fixture()
+def playlist() -> Playlist:
+    return Playlist(
+        id="pl-id-1",
+        owner_id="owner-1",
+        name="My Playlist",
+        description="A test playlist",
+        public=True,
+        tracks=[
+            Track(id="t-1", name="Song A", artists="Artist A", uri="spotify:track:t-1", album="Album A"),
+        ],
+    )
+
+
+# ---------------------------------------------------------------------------
+# save_playlist
+# ---------------------------------------------------------------------------
+
+
+class TestSavPlaylist:
+    def test_creates_yaml_file(self, playlist: Playlist, tmp_path: Path) -> None:
+        save_playlist(playlist, tmp_path)
+        assert (tmp_path / "playlist_pl-id-1.yaml").exists()
+
+    def test_creates_directory_if_missing(self, playlist: Playlist, tmp_path: Path) -> None:
+        target = tmp_path / "nested" / "dir"
+        save_playlist(playlist, target)
+        assert (target / "playlist_pl-id-1.yaml").exists()
+
+    def test_yaml_content_matches_playlist(self, playlist: Playlist, tmp_path: Path) -> None:
+        save_playlist(playlist, tmp_path)
+        with open(tmp_path / "playlist_pl-id-1.yaml", encoding="utf-8") as f:
+            data = yaml.safe_load(f)
+        assert data["id"] == "pl-id-1"
+        assert data["name"] == "My Playlist"
+        assert data["description"] == "A test playlist"
+        assert data["public"] is True
+        assert data["owner_id"] == "owner-1"
+        assert len(data["tracks"]) == 1
+        assert data["tracks"][0]["name"] == "Song A"
+
+    def test_overwrites_existing_file(self, playlist: Playlist, tmp_path: Path) -> None:
+        save_playlist(playlist, tmp_path)
+        playlist.description = "updated"
+        save_playlist(playlist, tmp_path)
+        with open(tmp_path / "playlist_pl-id-1.yaml", encoding="utf-8") as f:
+            data = yaml.safe_load(f)
+        assert data["description"] == "updated"
+
+    def test_playlist_with_no_tracks(self, tmp_path: Path) -> None:
+        playlist = Playlist(id="pl-empty", owner_id="o-1", name="Empty")
+        save_playlist(playlist, tmp_path)
+        with open(tmp_path / "playlist_pl-empty.yaml", encoding="utf-8") as f:
+            data = yaml.safe_load(f)
+        assert data["tracks"] == []
+
+    def test_unicode_name_preserved_in_content(self, tmp_path: Path) -> None:
+        # Non-ASCII letters pass isalpha(), so the full name is kept in the filename
+        playlist = Playlist(id="pl-unicode", owner_id="o-1", name="Café")
+        save_playlist(playlist, tmp_path)
+        with open(tmp_path / "playlist_pl-unicode.yaml", encoding="utf-8") as f:
+            data = yaml.safe_load(f)
+        assert data["name"] == "Café"