Skip to content

Commit 55c7874

Browse files
committed
feat: support --types-dir for proto generation
- Update all hardcoded 'internal' paths in genrpc to use config.C.Gen.TypesDir - Modified files: genrpc.go, pb.go, logic.go, middleware.go, server.go - Now proto generation also respects the --types-dir flag Closes #406
1 parent 410fedf commit 55c7874

5 files changed

Lines changed: 11 additions & 11 deletions

File tree

cmd/jzero/internal/command/gen/genrpc/genrpc.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -260,15 +260,15 @@ func (jr *JzeroRpc) Gen() (map[string]rpcparser.Proto, error) {
260260
if strings.HasPrefix(goPackage, jr.Module) {
261261
return goPackage
262262
}
263-
return filepath.ToSlash(filepath.Join(jr.Module, "internal", goPackage))
263+
return filepath.ToSlash(filepath.Join(jr.Module, config.C.Gen.TypesDir, goPackage))
264264
}(),
265265
jr.Module,
266266
rel,
267267
func() string {
268268
if strings.HasPrefix(goPackage, jr.Module) {
269269
return goPackage
270270
}
271-
return filepath.ToSlash(filepath.Join(jr.Module, "internal", goPackage))
271+
return filepath.ToSlash(filepath.Join(jr.Module, config.C.Gen.TypesDir, goPackage))
272272
}())
273273
}
274274

cmd/jzero/internal/command/gen/genrpc/logic.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ func (jr *JzeroRpc) GetAllLogicFiles(descFilepath string, protoSpec rpcparser.Pr
4545
return nil, err
4646
}
4747

48-
fp := filepath.Join(config.C.Wd(), "internal", "logic", strings.ToLower(service.Name), namingFormat+".go")
48+
fp := filepath.Join(config.C.Wd(), config.C.Gen.TypesDir, "logic", strings.ToLower(service.Name), namingFormat+".go")
4949

5050
f := LogicFile{
5151
Path: fp,

cmd/jzero/internal/command/gen/genrpc/middleware.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -163,8 +163,8 @@ func (jr *JzeroRpc) genApiMiddlewares(protoFiles []string) (err error) {
163163
return err
164164
}
165165
namingFormat, _ := format.FileNamingFormat(config.C.Style, v.Name+"Middleware")
166-
if !pathx.FileExists(filepath.Join("internal", "middleware", namingFormat+".go")) {
167-
err = os.WriteFile(filepath.Join("internal", "middleware", namingFormat+".go"), process, 0o644)
166+
if !pathx.FileExists(filepath.Join(config.C.Gen.TypesDir, "middleware", namingFormat+".go")) {
167+
err = os.WriteFile(filepath.Join(config.C.Gen.TypesDir, "middleware", namingFormat+".go"), process, 0o644)
168168
if err != nil {
169169
return err
170170
}
@@ -184,8 +184,8 @@ func (jr *JzeroRpc) genApiMiddlewares(protoFiles []string) (err error) {
184184
return err
185185
}
186186
namingFormat, _ := format.FileNamingFormat(config.C.Style, v.Name+"Middleware")
187-
if !pathx.FileExists(filepath.Join("internal", "middleware", namingFormat+".go")) {
188-
err = os.WriteFile(filepath.Join("internal", "middleware", namingFormat+".go"), process, 0o644)
187+
if !pathx.FileExists(filepath.Join(config.C.Gen.TypesDir, "middleware", namingFormat+".go")) {
188+
err = os.WriteFile(filepath.Join(config.C.Gen.TypesDir, "middleware", namingFormat+".go"), process, 0o644)
189189
if err != nil {
190190
return err
191191
}
@@ -205,7 +205,7 @@ func (jr *JzeroRpc) genApiMiddlewares(protoFiles []string) (err error) {
205205
return err
206206
}
207207

208-
err = os.WriteFile(filepath.Join("internal", "middleware", "middleware_gen.go"), process, 0o644)
208+
err = os.WriteFile(filepath.Join(config.C.Gen.TypesDir, "middleware", "middleware_gen.go"), process, 0o644)
209209
if err != nil {
210210
return err
211211
}

cmd/jzero/internal/command/gen/genrpc/pb.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ func (jr *JzeroRpc) genNoRpcServiceExcludeThirdPartyProto(protoDirPath string) e
5656
if strings.HasPrefix(goPackage, jr.Module) {
5757
return goPackage
5858
}
59-
return filepath.ToSlash(filepath.Join(jr.Module, "internal", goPackage))
59+
return filepath.ToSlash(filepath.Join(jr.Module, config.C.Gen.TypesDir, goPackage))
6060
}(),
6161
filepath.Join("."),
6262
jr.Module)

cmd/jzero/internal/command/gen/genrpc/server.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ func (jr *JzeroRpc) genServer(serverImports, pbImports ImportLines, registerServ
4040
if err != nil {
4141
return err
4242
}
43-
err = os.WriteFile(filepath.Join(config.C.Wd(), "internal", "server", "server.go"), serverFile, 0o644)
43+
err = os.WriteFile(filepath.Join(config.C.Wd(), config.C.Gen.TypesDir, "server", "server.go"), serverFile, 0o644)
4444
if err != nil {
4545
return err
4646
}
@@ -57,7 +57,7 @@ func (jr *JzeroRpc) GetAllServerFiles(descFilepath string, protoSpec rpcparser.P
5757
if err != nil {
5858
return nil, err
5959
}
60-
fp := filepath.Join(config.C.Wd(), "internal", "server", strings.ToLower(service.Name), namingFormat+".go")
60+
fp := filepath.Join(config.C.Wd(), config.C.Gen.TypesDir, "server", strings.ToLower(service.Name), namingFormat+".go")
6161

6262
f := ServerFile{
6363
DescFilepath: descFilepath,

0 commit comments

Comments
 (0)