feat(jzero): before executing command print command first

Author: jaronnie

cmd/jzero/internal/hooks/hooks.go

@@ -14,6 +14,12 @@ import (
 	"github.com/jzero-io/jzero/cmd/jzero/internal/pkg/execx"
 )
 
+var (
+	runOutputFn        = execx.RunOutput
+	printHookCommandFn = printHookCommand
+	printHookOutputFn  = printHookOutput
+)
+
 func Run(cmd *cobra.Command, hookAction, hooksName string, hooks []string) error {
 	wd, _ := os.Getwd()
 
@@ -51,10 +57,10 @@ func Run(cmd *cobra.Command, hookAction, hooksName string, hooks []string) error
 	}
 
 	for _, v := range hooks {
-		output, err := execx.RunOutput(v, wd, "JZERO_HOOK_TRIGGERED=true")
 		if !quiet {
-			printHookCommand(v, err == nil)
+			printHookCommandFn(v)
 		}
+		output, err := runOutputFn(v, wd, "JZERO_HOOK_TRIGGERED=true")
 		if err != nil {
 			lines := console.NormalizeErrorLines(output)
 			if len(lines) == 0 {
@@ -74,7 +80,7 @@ func Run(cmd *cobra.Command, hookAction, hooksName string, hooks []string) error
 			return console.MarkRenderedError(err)
 		}
 		if !quiet && output != "" {
-			printHookOutput(output)
+			printHookOutputFn(output)
 		}
 	}
 
@@ -121,14 +127,10 @@ func Run(cmd *cobra.Command, hookAction, hooksName string, hooks []string) error
 	return nil
 }
 
-func printHookCommand(command string, success bool) {
+func printHookCommand(command string) {
 	if strings.Contains(command, "\n") {
 		lines := strings.Split(command, "\n")
-		if success {
-			fmt.Printf("%s\n", console.BoxItem(console.Cyan("Executing")))
-		} else {
-			fmt.Printf("%s\n", console.BoxErrorItem(console.Cyan("Executing")))
-		}
+		fmt.Printf("%s\n", console.BoxInfoItem(console.Cyan("Executing")))
 		for _, line := range lines {
 			trimmedLine := strings.TrimSpace(line)
 			if trimmedLine != "" {
@@ -139,12 +141,7 @@ func printHookCommand(command string, success bool) {
 	}
 
 	item := fmt.Sprintf("%s %s", console.Cyan("Executing"), command)
-	if success {
-		fmt.Printf("%s\n", console.BoxItem(item))
-		return
-	}
-
-	fmt.Printf("%s\n", console.BoxErrorItem(item))
+	fmt.Printf("%s\n", console.BoxInfoItem(item))
 }
 
 func printHookOutput(output string) {

cmd/jzero/internal/hooks/hooks_test.go

@@ -0,0 +1,48 @@
+package hooks
+
+import (
+	"reflect"
+	"testing"
+
+	"github.com/spf13/cobra"
+)
+
+func TestRunPrintsHookCommandBeforeExecution(t *testing.T) {
+	cmd := &cobra.Command{Use: "test"}
+	cmd.Flags().Bool("quiet", false, "")
+
+	oldRunOutputFn := runOutputFn
+	oldPrintHookCommandFn := printHookCommandFn
+	oldPrintHookOutputFn := printHookOutputFn
+	t.Cleanup(func() {
+		runOutputFn = oldRunOutputFn
+		printHookCommandFn = oldPrintHookCommandFn
+		printHookOutputFn = oldPrintHookOutputFn
+	})
+
+	var calls []string
+	printHookCommandFn = func(command string) {
+		calls = append(calls, "print:"+command)
+	}
+	runOutputFn = func(arg, dir string, env ...string) (string, error) {
+		calls = append(calls, "run:"+arg)
+		return "hook output", nil
+	}
+	printHookOutputFn = func(output string) {
+		calls = append(calls, "output:"+output)
+	}
+
+	if err := Run(cmd, "Before", "gen", []string{"echo test"}); err != nil {
+		t.Fatalf("Run() error = %v", err)
+	}
+
+	want := []string{
+		"print:echo test",
+		"run:echo test",
+		"output:hook output",
+	}
+
+	if !reflect.DeepEqual(calls, want) {
+		t.Fatalf("Run() calls = %v, want %v", calls, want)
+	}
+}

cmd/jzero/internal/pkg/console/console.go

@@ -61,6 +61,11 @@ func BoxItem(item string) string {
 	return fmt.Sprintf("│  %s %s", CheckMark(), item)
 }
 
+// BoxInfoItem creates a neutral informational box item.
+func BoxInfoItem(item string) string {
+	return fmt.Sprintf("│  %s %s", Cyan(">"), item)
+}
+
 // BoxErrorItem 创建box样式的错误条目
 func BoxErrorItem(item string) string {
 	return fmt.Sprintf("│  %s %s", CrossMark(), item)

cmd/jzero/internal/pkg/console/console_test.go

@@ -10,6 +10,14 @@ func TestBoxErrorItem(t *testing.T) {
 	}
 }
 
+func TestBoxInfoItem(t *testing.T) {
+	got := BoxInfoItem("Executing echo test")
+	want := "│  " + Cyan(">") + " Executing echo test"
+	if got != want {
+		t.Fatalf("BoxInfoItem() = %q, want %q", got, want)
+	}
+}
+
 func TestBoxFooters(t *testing.T) {
 	if got, want := BoxSuccessFooter(), "└─ "+Cyan("✓")+" "+Cyan("Complete"); got != want {
 		t.Fatalf("BoxSuccessFooter() = %q, want %q", got, want)