Commit 3ebabf9
Forge
[AISOS-376-ci-fix] Fix CI failures: lint and codegen
Detailed description:
- Added //nolint:kubeapilinter to ResyncPeriod *metav1.Duration field in
api/v1alpha1/controller_options.go and cmd/resource-generator/data/api.template
to suppress the nodurations lint rule (kubeapi linter requires integer types
with units in the name instead of Duration, but metav1.Duration is appropriate
for user-facing duration configuration)
- Re-ran make generate to propagate the nolint comment to all 23
api/v1alpha1/zz_generated.*-resource.go files
- Added //nolint:unparam to makeProgressingCondition in controller_test.go
since the observedGeneration parameter always receives 1 in tests
- Re-ran make generate to update generated docs and test fixtures:
website/docs/crd-reference.md, website/docs/development/godoc/generic-interfaces.md
internal/controllers/flavor/adapter_test.go,
internal/controllers/generic/reconciler/resource_actions_unmanaged_test.go
- Verified: make lint, make verify-fmt, and git diff --exit-code all pass
Closes: AISOS-376-ci-fix1 parent 5c6a3fd commit 3ebabf9
30 files changed
Lines changed: 117 additions & 45 deletions
File tree
- api/v1alpha1
- cmd/resource-generator/data
- internal/controllers
- flavor
- generic/reconciler
- website/docs
- development/godoc
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
80 | | - | |
| 80 | + | |
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments