Merge pull request #765 from shiftstack/reconcile-attached-down-ports

Fix port status not updating to ACTIVE after server interface attachment

Author: mandre

internal/controllers/port/controller.go

@@ -208,6 +208,12 @@ func serverToPortMapFunc(ctx context.Context, k8sClient client.Client) handler.M
 					log.V(logging.Verbose).Info("port needs reconciliation: listed in server status but deviceID not set",
 						"port", client.ObjectKeyFromObject(port),
 						"server", client.ObjectKeyFromObject(server))
+				} else if portStatus.Status == PortStatusDown {
+					shouldReconcile = true
+					reason = "Port attached to server but status is still DOWN"
+					log.V(logging.Verbose).Info("port needs reconciliation: attached to server but status is DOWN",
+						"port", client.ObjectKeyFromObject(port),
+						"server", client.ObjectKeyFromObject(server))
 				}
 			}
 

internal/controllers/volume/controller.go

@@ -162,6 +162,12 @@ func serverToVolumeMapFunc(ctx context.Context, k8sClient client.Client) handler
 					log.V(logging.Verbose).Info("volume needs reconciliation: listed in server status but no attachment info",
 						"volume", client.ObjectKeyFromObject(volume),
 						"server", client.ObjectKeyFromObject(server))
+				} else if volumeStatus.Status != VolumeStatusInUse {
+					shouldReconcile = true
+					reason = "Volume attached to server but status is not in-use"
+					log.V(logging.Verbose).Info("volume needs reconciliation: attached to server but status is not in-use",
+						"volume", client.ObjectKeyFromObject(volume),
+						"server", client.ObjectKeyFromObject(server))
 				}
 			}