api: explicitly set default marker to +kubebuilder:default

kube-api-linter prefers using the `+default` marker and will warn about
our use of `+kubebuilder:default`. We could switch the API to use
`+default`, however `elastic/crd-ref-docs` doesn't yet understand this
marker. A patch merged to add support but it's not yet in a release.

Let's stick to `+kubebuilder:default` for now.

Author: mandre

.golangci.yml

@@ -35,12 +35,12 @@ linters:
           linters:
             disable:
               - arrayofstruct
-              - defaults
               - nonpointerstructs
               - optionalfields
             enable:
               - commentstart
               - conditions
+              - defaults
               - duplicatemarkers
               - integers
               - jsontags
@@ -65,6 +65,9 @@ linters:
               isFirstField: Warn
               usePatchStrategy: Ignore
               useProtobuf: Forbid
+            defaults:
+              # Let's use `+kubebuilder:default` until elastic/crd-ref-docs supports `+default`
+              preferredDefaultMarker: "kubebuilder:default"
             requiredfields:
               omitempty:
                 policy: Ignore