Poll for port/volume status when attached but not yet transitioned

After a port is attached to a server, its Neutron status transitions
asynchronously from DOWN to ACTIVE. Similarly, a volume transitions
from available to in-use after attachment. The cross-controller
signaling via serverTo{Port,Volume}MapFunc is susceptible to a race
with the controller's own status write.

Add defense-in-depth polling: when the port has a device_id but
status is still DOWN, or when a volume has attachments but status
is not in-use, schedule a re-fetch via WaitingOnOpenStack. This
ensures the controller picks up the status transition regardless
of whether the cross-controller signal is lost.

Author: mandre

internal/controllers/port/actuator.go

@@ -396,6 +396,21 @@ func (actuator portActuator) checkAttachedServer(ctx context.Context, obj orcObj
 		}
 	}
 
+	// When the port is attached to a device but still reports DOWN,
+	// the Neutron status has not yet transitioned to ACTIVE (e.g.
+	// OVN is still binding the port). Schedule a re-fetch so we
+	// pick up the ACTIVE status without relying solely on the
+	// cross-controller serverToPortMapFunc signal, which is
+	// susceptible to a race with the port controller's own status
+	// write.
+	if osResource.Status == PortStatusDown {
+		log.V(logging.Verbose).Info("Port is attached but status is still DOWN, polling for status change",
+			"port", obj.Name,
+			"deviceID", osResource.DeviceID,
+			"status", osResource.Status)
+		return progress.WaitingOnOpenStack(progress.WaitingOnReady, serverBuildPollingPeriod)
+	}
+
 	return nil
 }
 

internal/controllers/volume/actuator.go

@@ -283,10 +283,29 @@ func handleDescriptionUpdate(updateOpts *volumes.UpdateOpts, resource *resourceS
 
 func (actuator volumeActuator) GetResourceReconcilers(ctx context.Context, orcObject orcObjectPT, osResource *osResourceT, controller interfaces.ResourceController) ([]resourceReconciler, progress.ReconcileStatus) {
 	return []resourceReconciler{
+		actuator.checkAttachmentStatus,
 		actuator.updateResource,
 	}, nil
 }
 
+func (volumeActuator) checkAttachmentStatus(ctx context.Context, _ orcObjectPT, osResource *osResourceT) progress.ReconcileStatus {
+	log := ctrl.LoggerFrom(ctx)
+
+	// When the volume has attachments but Cinder still reports
+	// "available" rather than "in-use", the status transition has
+	// not completed yet. Schedule a re-fetch so we pick up the
+	// updated status without relying solely on the cross-controller
+	// serverToVolumeMapFunc signal, which is susceptible to a race
+	// with the volume controller's own status write.
+	if len(osResource.Attachments) > 0 && osResource.Status != VolumeStatusInUse {
+		log.V(logging.Verbose).Info("Volume has attachments but status is not in-use, polling for status change",
+			"status", osResource.Status)
+		return progress.WaitingOnOpenStack(progress.WaitingOnReady, volumeAvailablePollingPeriod)
+	}
+
+	return nil
+}
+
 type volumeHelperFactory struct{}
 
 var _ helperFactory = volumeHelperFactory{}