Skip to content

Commit 6493caa

Browse files
luke-gruberluke-gru
authored andcommitted
Skip failing Ractor test in CI
Ractor-local GC will change how this works so it doesn't make sense to fix it now. Add a comment so we come back to it when ractor-local GC lands.
1 parent b2cf20f commit 6493caa

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

test/-ext-/thread/test_instrumentation_api.rb

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,8 @@ def test_queue_releases_gvl
134134
end
135135

136136
def test_blocking_on_ractor
137+
# TODO: turn back on and fix when ractor-local GC (rlgc) lands
138+
omit "this is failing CI and rlgc will change how this works so let's wait until it lands to fix it" if ENV["GITHUB_WORKFLOW"]
137139
assert_ractor(<<-"RUBY", require_relative: "helper", require: "-test-/thread/instrumentation")
138140
include ThreadInstrumentation::TestHelper
139141
@@ -161,7 +163,8 @@ def test_blocking_on_ractor
161163
end
162164

163165
def test_sleeping_inside_ractor
164-
omit "This test is flaky and intermittently failing now on ModGC workflow" if ENV['GITHUB_WORKFLOW'] == 'ModGC'
166+
# TODO: turn back and fix when ractor-local GC (rlgc) lands
167+
omit "This test is flaky and intermittently failing" if ENV['GITHUB_WORKFLOW']
165168

166169
assert_ractor(<<-"RUBY", require_relative: "helper", require: "-test-/thread/instrumentation")
167170
include ThreadInstrumentation::TestHelper

0 commit comments

Comments
 (0)