perf: batch branch commit-message lookups in shell completion#187
Open
tksm wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git wt's shell completion previously forkedgit log -1once per branch to fetch each branch's commit subject, which became slow in repositories with many local or remote-tracking branches. This change batches the lookup into a singlegit for-each-refcall. In a 500-branch reproduction, completion drops from ~2.2s to ~0.12s (~20x faster).Reproduction
The reproduction below uses local branches only for simplicity.
git-wtis the released binary andgit-wt-fixedis built from this branch.With the fix applied:
I confirmed the completion output is identical before/after.