Commit d151718
committed
ui: resolve node label/color/hover columns to ColInfo in GraphWidget
vis.proto added Graph.{node_label,node_color,node_hover}_column +
NodeThresholds in commit 94f1c86; graph.tsx's GraphProps typed the
new node-side fields as ColInfo to mirror the existing edge fields,
but the GraphWidget caller only spread `{...display}` (raw strings
from the vis spec) and resolved just the edge columns through
colInfoFromName. That broke prod with:
graph.tsx(353,10): error TS2322:
Types of property 'nodeLabelColumn' are incompatible.
Type 'string' is not assignable to type 'ColInfo'.
Resolve nodeLabelColumn, nodeColorColumn, and the new nodeHoverInfo
array through colInfoFromName the same way the edge equivalents are
resolved, and pass them explicitly to <Graph> so they override the
raw strings from the spread.
Verified locally: bazel build --config=stamp --config=x86_64_sysroot
//src/ui:ui_bundle now produces ui_bundle.tar.gz cleanly (6.1 MB).
v0.0.11 cloud-release tag hit the same TS error in CI; v0.0.12 will
be cut from this commit.1 parent 47c14cc commit d151718
1 file changed
Lines changed: 14 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
339 | 339 | | |
340 | 340 | | |
341 | 341 | | |
| 342 | + | |
| 343 | + | |
342 | 344 | | |
343 | 345 | | |
344 | 346 | | |
| |||
348 | 350 | | |
349 | 351 | | |
350 | 352 | | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
351 | 362 | | |
352 | 363 | | |
353 | 364 | | |
| |||
357 | 368 | | |
358 | 369 | | |
359 | 370 | | |
| 371 | + | |
| 372 | + | |
360 | 373 | | |
361 | 374 | | |
| 375 | + | |
362 | 376 | | |
363 | 377 | | |
364 | 378 | | |
| |||
0 commit comments