Commit dd3d58c
Reduce boiler plate for Go container image C++ headers (pixie-io#2307)
Summary: Reduce boiler plate for Go container image C++ headers
Previously, adding a new Go version required:
1. Creating new header files for each container type (grpc_server,
grpc_client, tls_server, tls_client)
2. Adding BUILD.bazel entries for each new library
3. Updating test files with new #include statements
These header files account for ~100-200 lines of boilerplate code per Go
version (~50 lines for each grpc and tls client/server pair) and add
overhead when upgrading our Go version.
This PR reduces this boilerplate by generating these files with a new
Bazel macro `go_container_libraries`. This macro generates:
- Individual C++ headers for each version (e.g.,
`go_1_24_grpc_server_container.h`)
- Aggregate headers that include all versions for a given container type
(e.g., `go_grpc_server_containers.h`, `go_tls_client_containers.h`)
Relevant Issues: N/A
Type of change: /kind cleanup
Test Plan: Build should succeed
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
GitOrigin-RevId: ce714e61 parent d549b47 commit dd3d58c
2 files changed
Lines changed: 4 additions & 83 deletions
File tree
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | | - | |
74 | 73 | | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
88 | 77 | | |
89 | 78 | | |
90 | | - | |
| 79 | + | |
91 | 80 | | |
92 | 81 | | |
93 | 82 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | 19 | | |
23 | 20 | | |
24 | | - | |
25 | 21 | | |
26 | 22 | | |
27 | 23 | | |
28 | | - | |
29 | 24 | | |
30 | 25 | | |
31 | 26 | | |
| |||
395 | 390 | | |
396 | 391 | | |
397 | 392 | | |
398 | | - | |
399 | | - | |
400 | | - | |
401 | | - | |
402 | | - | |
403 | | - | |
404 | | - | |
405 | | - | |
406 | | - | |
407 | | - | |
408 | | - | |
409 | | - | |
410 | | - | |
411 | | - | |
412 | | - | |
413 | | - | |
414 | | - | |
415 | | - | |
416 | | - | |
417 | | - | |
418 | | - | |
419 | | - | |
420 | | - | |
421 | | - | |
422 | | - | |
423 | | - | |
424 | | - | |
425 | | - | |
426 | | - | |
427 | | - | |
428 | | - | |
429 | | - | |
430 | | - | |
431 | | - | |
432 | | - | |
433 | | - | |
434 | | - | |
435 | | - | |
436 | | - | |
437 | | - | |
438 | | - | |
439 | | - | |
440 | | - | |
441 | | - | |
442 | | - | |
443 | | - | |
444 | | - | |
445 | | - | |
446 | | - | |
447 | | - | |
448 | | - | |
449 | | - | |
450 | | - | |
451 | | - | |
452 | | - | |
453 | | - | |
454 | | - | |
455 | | - | |
456 | | - | |
457 | | - | |
458 | | - | |
459 | | - | |
460 | | - | |
461 | 393 | | |
462 | 394 | | |
0 commit comments