Skip to content

Commit de89eab

Browse files
committed
Add docker debugging info. Remove expensive clang-tidy build temporarily
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
1 parent 2942e09 commit de89eab

1 file changed

Lines changed: 42 additions & 32 deletions

File tree

.github/workflows/build_and_test.yaml

Lines changed: 42 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -35,32 +35,32 @@ jobs:
3535
with:
3636
image-base-name: "dev_image_with_extras"
3737
ref: ${{ needs.env-protect-setup.outputs.ref }}
38-
clang-tidy:
39-
runs-on: oracle-vm-16cpu-64gb-x86-64
40-
needs: [authorize, env-protect-setup, get-dev-image]
41-
container:
42-
image: ${{ needs.get-dev-image.outputs.image-with-tag }}
43-
steps:
44-
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
45-
with:
46-
fetch-depth: 0
47-
ref: ${{ needs.env-protect-setup.outputs.ref }}
48-
- name: Add pwd to git safe dir
49-
run: git config --global --add safe.directory `pwd`
50-
- name: get bazel config
51-
uses: ./.github/actions/bazelrc
52-
with:
53-
BB_API_KEY: ${{ secrets.BB_IO_API_KEY }}
54-
- name: Save Diff Info
55-
run: ./ci/save_diff_info.sh
56-
- name: Run Clang Tidy
57-
shell: bash
58-
run: |
59-
diff_file="diff_origin_main_cc"
60-
if [[ "${{ github.event_name }}" == "push" ]] || [[ "${{ github.event_name }}" == "schedule" ]]; then
61-
diff_file="diff_head_cc"
62-
fi
63-
./ci/run_clang_tidy.sh -f "${diff_file}"
38+
# clang-tidy:
39+
# runs-on: oracle-vm-16cpu-64gb-x86-64
40+
# needs: [authorize, env-protect-setup, get-dev-image]
41+
# container:
42+
# image: ${{ needs.get-dev-image.outputs.image-with-tag }}
43+
# steps:
44+
# - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
45+
# with:
46+
# fetch-depth: 0
47+
# ref: ${{ needs.env-protect-setup.outputs.ref }}
48+
# - name: Add pwd to git safe dir
49+
# run: git config --global --add safe.directory `pwd`
50+
# - name: get bazel config
51+
# uses: ./.github/actions/bazelrc
52+
# with:
53+
# BB_API_KEY: ${{ secrets.BB_IO_API_KEY }}
54+
# - name: Save Diff Info
55+
# run: ./ci/save_diff_info.sh
56+
# - name: Run Clang Tidy
57+
# shell: bash
58+
# run: |
59+
# diff_file="diff_origin_main_cc"
60+
# if [[ "${{ github.event_name }}" == "push" ]] || [[ "${{ github.event_name }}" == "schedule" ]]; then
61+
# diff_file="diff_head_cc"
62+
# fi
63+
# ./ci/run_clang_tidy.sh -f "${diff_file}"
6464
code-coverage:
6565
if: github.event_name == 'push'
6666
needs: [authorize, env-protect-setup, get-dev-image]
@@ -85,7 +85,7 @@ jobs:
8585
run: |
8686
# Github actions container runner creates a docker network without IPv6 support. We enable it manually.
8787
sysctl -w net.ipv6.conf.lo.disable_ipv6=0
88-
./ci/collect_coverage.sh -u -b main -c "$(git rev-parse HEAD)" -r pixie-io/pixie
88+
./ci/collect_coverage.sh -u -b main -c "$(git rev-parse HEAD)" -r k8sstormcenter/pixie
8989
generate-matrix:
9090
needs: [authorize, env-protect-setup, get-dev-image]
9191
runs-on: oracle-vm-16cpu-64gb-x86-64
@@ -154,6 +154,17 @@ jobs:
154154
${{ matrix.args }} \
155155
--target_pattern_file=target_files/${{ matrix.buildables }} \
156156
2> >(tee bazel_stderr)
157+
- name: Debug Docker networking
158+
if: ${{ matrix.tests }}
159+
shell: bash
160+
run: |
161+
docker info
162+
docker network inspect bridge
163+
docker run --rm postgres:13.3 echo "pull works"
164+
CID=$(docker run -d --rm -e POSTGRES_PASSWORD=secret postgres:13.3)
165+
sleep 2
166+
docker inspect "$CID" --format '{{json .NetworkSettings}}' | jq '{Gateway: .Gateway, IPAddress: .IPAddress, Bridge: .Bridge, Networks: .Networks}'
167+
docker stop "$CID"
157168
- name: Test ${{ matrix.name }}
158169
if: ${{ matrix.tests }}
159170
shell: bash
@@ -185,19 +196,18 @@ jobs:
185196
shell: bash
186197
build-and-test-status:
187198
if: always()
188-
needs: [build-and-test, clang-tidy, generate-matrix]
199+
needs: [build-and-test, generate-matrix]
189200
runs-on: ubuntu-latest
190201
steps:
191-
- if: needs.build-and-test.result == 'success' && needs.clang-tidy.result == 'success'
202+
- if: needs.build-and-test.result == 'success'
192203
run: echo "Build and Test complete ✓"
193204
- if: >
194-
needs.generate-matrix.result == 'success' && needs.clang-tidy.result == 'success'
205+
needs.generate-matrix.result == 'success'
195206
&& needs.build-and-test.result == 'skipped'
196207
run: echo "Build and Test skipped no matrix configs generated ✓"
197208
- if: >
198-
!(needs.build-and-test.result == 'success' && needs.clang-tidy.result == 'success') &&
209+
!(needs.build-and-test.result == 'success'
199210
!(needs.generate-matrix.result == 'success' &&
200-
needs.clang-tidy.result == 'success' &&
201211
needs.build-and-test.result == 'skipped')
202212
run: |
203213
echo "Build and Test failed"

0 commit comments

Comments
 (0)