Conversation
Signed-off-by: entlein <einentlein@gmail.com>
entlein
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
ddelnano
reviewed
Apr 21, 2026
entlein
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
entlein
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
Author
|
merged in your e2e-clickhouse branch for local testing. A good time to setup that linter... |
ddelnano
reviewed
Apr 22, 2026
ddelnano
left a comment
ddelnano
left a comment
There was a problem hiding this comment.
I like the approach of this (having quiet ticks and different export modes).
I think this is the right harness, but we have to decide whether we will use the plugin system for its scheduling and script execution reporting or we will handle that entirely in this service. See my more detailed notes in this comment.
entlein
force-pushed
the
entlein/adaptive-export-config
branch
from
418092c to
1b3b64a
Compare
entlein
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
…e schema_creation option , probably needs complete rewrite, this is to make it work e2e for the lab now Signed-off-by: entlein <einentlein@gmail.com>
entlein
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
Signed-off-by: entlein <einentlein@gmail.com>
entlein
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
Signed-off-by: entlein <einentlein@gmail.com>
entlein
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
Signed-off-by: entlein <einentlein@gmail.com>
entlein
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
Signed-off-by: entlein <einentlein@gmail.com>
entlein
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
Signed-off-by: entlein <einentlein@gmail.com>
entlein
temporarily deployed
to
pr-actions-approval
GitHub Actions
Inactive
ddelnano
reviewed
Apr 23, 2026
Comment on lines
+26
to
+28
| # v0.36.0 released 2026-04-22 (post-incident). Internally SHA-pins | ||
| # setup-trivy@3fb12ec = Aqua's safe v0.2.6 per GHSA-69fq-xp46-6x23. | ||
| - uses: aquasecurity/trivy-action@ed142fd0673e97e23eac54620cfb913e5ce36c25 # v0.36.0 |
There was a problem hiding this comment.
This was fixed upstream (pixie-io#2335), but because we are ignoring certain file paths copybara is ignoring it.
ddelnano
reviewed
Apr 23, 2026
Comment on lines
+314
to
+318
| // Filter presets by an allow-list of case-insensitive substrings in the | ||
| // script name. Useful when the destination ClickHouse doesn't have every | ||
| // target table pre-created (Pixie's C++ ClickHouseExportSinkNode aborts | ||
| // kelvin on UNKNOWN_TABLE from CH — upstream bug), so we must not install | ||
| // retention scripts whose target table is missing. |
There was a problem hiding this comment.
Sorry these presets were a footgun. I just added whatever we used for Atlanta. We can remove those if they don't make sense anymore.
I think having this ALLOWED_RETENTION_SCRIPTS is nice to keep regardless of what we do with the clickhouse plugin default scripts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Temporarily adding a dynamic method to toggle the plugin for clickhouse
Test Plan: manual
Type of change: /kind temporary