Skip to content

fix(dx_evidence_graph): coalesce node identity to pod→service→IP (don't collapse empty-pod peers) #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
entlein wants to merge 1 commit into
base: entlein/dx-evidence-graph-viz
Choose a base branch
from
Open

fix(dx_evidence_graph): coalesce node identity to pod→service→IP (don't collapse empty-pod peers) #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/pxl_scripts/px/dx_evidence_graph/dx_evidence_graph.pxl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,19 @@ import px

def dx_attack_graph(start_time: str, clickhouse_dsn: str, table: str):
df = px.DataFrame(table, clickhouse_dsn=clickhouse_dsn, start_time=start_time)
return df[['requestor_pod', 'responder_pod',
# Node identity: pod, else service, else IP. Edges whose peer is an IP or a
# non-pod entity (the k8s API server, an external endpoint, a consulted
# socket) have an empty *_pod; keying the graph on *_pod alone collapses ALL
# of them into one bogus "" node. Coalesce so each distinct peer is its own
# node — same idiom Pixie's net_flow_graph uses (px.select(src=='', src_ip, src)).
df.requestor = px.select(df.requestor_pod == '',
px.select(df.requestor_service == '', df.requestor_ip, df.requestor_service),
df.requestor_pod)
df.responder = px.select(df.responder_pod == '',
px.select(df.responder_service == '', df.responder_ip, df.responder_service),
df.responder_pod)
return df[['requestor', 'responder',
'requestor_pod', 'responder_pod',
'requestor_service', 'responder_service',
'requestor_ip', 'responder_ip',
'weight', 'max_severity', 'confidence',
Expand Down
4 changes: 2 additions & 2 deletions src/pxl_scripts/px/dx_evidence_graph/vis.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
"displaySpec": {
"@type": "types.px.dev/px.vispb.Graph",
"adjacencyList": {
"fromColumn": "requestor_pod",
"toColumn": "responder_pod"
"fromColumn": "requestor",
"toColumn": "responder"
},
"edgeWeightColumn": "weight",
"edgeColorColumn": "max_severity",
Expand Down
Loading