Skip to content

Commit 2f6dc28

Browse files
chore: Deprecate auto-gomaxprocs with natively handles container CPU quotas in GO v1.25 (#1817)
ref: https://go.dev/blog/container-aware-gomaxprocs Signed-off-by: dongjiang <dongjiang1989@126.com>
1 parent 26ba663 commit 2f6dc28

4 files changed

Lines changed: 0 additions & 27 deletions

File tree

go/core/internal/goruntime/cpu.go

Lines changed: 0 additions & 19 deletions
This file was deleted.

go/core/pkg/app/app.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ import (
7575

7676
"github.com/kagent-dev/kagent/go/api/v1alpha2"
7777
"github.com/kagent-dev/kagent/go/core/internal/controller"
78-
"github.com/kagent-dev/kagent/go/core/internal/goruntime"
7978
"github.com/kagent-dev/kmcp/api/v1alpha1"
8079
corev1 "k8s.io/api/core/v1"
8180
agentsandboxv1 "sigs.k8s.io/agent-sandbox/api/v1alpha1"
@@ -345,8 +344,6 @@ func Start(getExtensionConfig GetExtensionConfig, migrationRunner MigrationRunne
345344

346345
setupLog.Info("Starting KAgent Controller", "version", Version, "git_commit", GitCommit, "build_date", BuildDate, "config", cfg)
347346

348-
goruntime.SetMaxProcs(logger)
349-
350347
// if the enable-http2 flag is false (the default), http/2 should be disabled
351348
// due to its vulnerabilities. More specifically, disabling http/2 will
352349
// prevent from being vulnerable to the HTTP/2 Stream Cancellation and

go/go.mod

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ require (
4444
go.opentelemetry.io/otel v1.43.0
4545
go.opentelemetry.io/otel/sdk v1.43.0
4646
go.opentelemetry.io/otel/trace v1.43.0
47-
go.uber.org/automaxprocs v1.6.0
4847
go.uber.org/zap v1.27.1
4948
golang.org/x/text v0.36.0
5049
google.golang.org/adk v1.1.0

go/go.sum

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -404,8 +404,6 @@ github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 h1:Jamvg5psRI
404404
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
405405
github.com/power-devops/perfstat v0.0.0-20240221224432-82ca36839d55 h1:o4JXh1EVt9k/+g42oCprj/FisM4qX9L3sZB3upGN2ZU=
406406
github.com/power-devops/perfstat v0.0.0-20240221224432-82ca36839d55/go.mod h1:OmDBASR4679mdNQnz2pUhc2G8CO2JrUAVFDRBDP/hJE=
407-
github.com/prashantv/gostub v1.1.0 h1:BTyx3RfQjRHnUWaGF9oQos79AlQ5k8WNktv7VGvVH4g=
408-
github.com/prashantv/gostub v1.1.0/go.mod h1:A5zLQHz7ieHGG7is6LLXLz7I8+3LZzsrV0P1IAHhP5U=
409407
github.com/prometheus/client_golang v1.23.2 h1:Je96obch5RDVy3FDMndoUsjAhG5Edi49h0RJWRi/o0o=
410408
github.com/prometheus/client_golang v1.23.2/go.mod h1:Tb1a6LWHB3/SPIzCoaDXI4I8UHKeFTEQ1YCr+0Gyqmg=
411409
github.com/prometheus/client_model v0.6.2 h1:oBsgwpGs7iVziMvrGhE53c/GrLUsZdHnqNwqPLxwZyk=
@@ -562,8 +560,6 @@ go.opentelemetry.io/otel/trace v1.43.0 h1:BkNrHpup+4k4w+ZZ86CZoHHEkohws8AY+WTX09
562560
go.opentelemetry.io/otel/trace v1.43.0/go.mod h1:/QJhyVBUUswCphDVxq+8mld+AvhXZLhe+8WVFxiFff0=
563561
go.opentelemetry.io/proto/otlp v1.10.0 h1:IQRWgT5srOCYfiWnpqUYz9CVmbO8bFmKcwYxpuCSL2g=
564562
go.opentelemetry.io/proto/otlp v1.10.0/go.mod h1:/CV4QoCR/S9yaPj8utp3lvQPoqMtxXdzn7ozvvozVqk=
565-
go.uber.org/automaxprocs v1.6.0 h1:O3y2/QNTOdbF+e/dpXNNW7Rx2hZ4sTIPyybbxyNqTUs=
566-
go.uber.org/automaxprocs v1.6.0/go.mod h1:ifeIMSnPZuznNm6jmdzmU3/bfk01Fe2fotchwEFJ8r8=
567563
go.uber.org/goleak v1.3.0 h1:2K3zAYmnTNqV73imy9J1T3WC+gmCePx2hEGkimedGto=
568564
go.uber.org/goleak v1.3.0/go.mod h1:CoHD4mav9JJNrW/WLlf7HGZPjdw8EucARQHekz1X6bE=
569565
go.uber.org/multierr v1.11.0 h1:blXXJkSxSSfBVBlC76pxqeO+LN3aDfLQo+309xJstO0=

0 commit comments

Comments
 (0)