add downstream extension points#831
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds extension points to enable downstream forks and extensions of the kagent codebase by introducing plugin interfaces and refactoring the main application startup to use a callback pattern for configuration.
- Introduces plugin interfaces for extending agent translation and MCP server functionality
- Refactors the main startup function to accept configuration through a callback pattern
- Updates dependencies to support the new extension architecture
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| go/pkg/translator/adk_api_translator_types.go | Defines new plugin types and data structures for extension points |
| go/pkg/app/app.go | Refactors main startup function to use callback-based configuration |
| go/internal/httpserver/handlers/agents.go | Updates agent handler to pass nil plugins to translator |
| go/internal/controller/translator/adk_api_translator.go | Integrates plugin support into the ADK API translator |
| go/go.mod | Updates kmcp dependency version |
| go/cmd/controller/main.go | Updates main function to use new callback-based startup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
yuval-k
reviewed
Sep 2, 2025
| "strconv" | ||
| "strings" | ||
|
|
||
| "go.uber.org/multierr" |
Collaborator
There was a problem hiding this comment.
we can use stdlib error.Join instead
EItanya
reviewed
Sep 2, 2025
| podTemplateAnnotations = map[string]string{} | ||
| } | ||
| // Add config hash annotation to pod template to force rollout on config changes | ||
| podTemplateAnnotations["kagent.dev/config-hash"] = fmt.Sprintf("%d", configHash) |
Contributor
There was a problem hiding this comment.
We only want to add this if config hash is set
Collaborator
Author
There was a problem hiding this comment.
apparently we always set it now
EItanya
previously approved these changes
Sep 3, 2025
EItanya
left a comment
EItanya
left a comment
Contributor
There was a problem hiding this comment.
Changes look good to me, but commits need to be signed for DCO before we can merge
Signed-off-by: Scott Weiss <sdw35@cornell.edu>
ilackarms
force-pushed
the
add-extension-points
branch
from
a68ce08 to
52e92dc
Compare
EItanya
approved these changes
Sep 3, 2025
Raghavendiran-2002
pushed a commit
to Raghavendiran-2002/kagent
that referenced
this pull request
Apr 30, 2026
adds extension points for downstream forks / extensions of the core kagent code base depends on kagent-dev/kmcp#78 Signed-off-by: Scott Weiss <sdw35@cornell.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds extension points for downstream forks / extensions of the core kagent code base
depends on kagent-dev/kmcp#78