Skip to content

Commit 6298025

Browse files
authored
fix: Push images workflow failure (#84)
Fixes an issue introduced in #79 where we were trying to retag a pushed image that wasn't available in our local repository in our CI workflow. Signed-off-by: JM Huibonhoa <jm.huibonhoa@solo.io>
1 parent bfb599a commit 6298025

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

Makefile

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -240,10 +240,8 @@ docker-build: ## Build docker image with the manager.
240240
.PHONY: docker-tag-latest
241241
docker-tag-latest: ## Tag the built image as 'latest' and push it
242242
@echo "Tagging image as 'latest'..."
243-
@docker tag ${CONTROLLER_IMG} $(DOCKER_REGISTRY)/$(DOCKER_REPO)/$(CONTROLLER_IMAGE_NAME):latest
244-
@echo "Pushing 'latest' tag..."
245-
@docker push $(DOCKER_REGISTRY)/$(DOCKER_REPO)/$(CONTROLLER_IMAGE_NAME):latest
246-
@echo "Latest tag pushed successfully"
243+
@$(DOCKER_BUILDER) imagetools create --tag $(DOCKER_REGISTRY)/$(DOCKER_REPO)/$(CONTROLLER_IMAGE_NAME):latest $(CONTROLLER_IMG)
244+
@echo "Latest tag created successfully"
247245

248246
.PHONY: docker-push
249247
docker-push: ## Push docker image with the manager.

0 commit comments

Comments
 (0)