Conversation
yuval-k
reviewed
Jul 10, 2025
| @@ -0,0 +1,25 @@ | |||
| { | |||
| "name": "Kubebuilder DevContainer", | |||
There was a problem hiding this comment.
do we need devcontainer? i'm ok to keep if provides value
| go-version-file: go.mod | ||
|
|
||
| - name: Install the latest version of kind | ||
| run: | |
| Containers: []corev1.Container{{ | ||
| Name: "mcp-server", | ||
| Image: image, | ||
| Command: []string{ |
There was a problem hiding this comment.
you may want to override the original agent args; i think otherwise you will get random arguments from the original image.
maybe command can be "/agentbin/agentgateway" and args can be ["-f" "/config/local.yaml"]
| { | ||
| Name: "mcp-server", | ||
| Image: image, | ||
| Command: []string{server.Spec.Deployment.Cmd}, |
There was a problem hiding this comment.
command and args should be nil if it is empty in the deployment; so the image default command/args can be used
yuval-k
approved these changes
Jul 11, 2025
jmhbh
pushed a commit
that referenced
this pull request
Jul 28, 2025
* create kubebuilder base + put down api foundation * create foundation for kmcp translator * refactor api, support http server * fix build, regenerate * wire up controller, add api for targetport * fixes, get e2e test working * working e2e test * address pr feedback * bump golint action version * fix golangci config * remove unused files * fix linter, add http path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.