From d24099ef09f68d4f01b873e8cf4703ae2b30441d Mon Sep 17 00:00:00 2001 From: JM Huibonhoa Date: Mon, 24 Nov 2025 09:58:06 -0500 Subject: [PATCH 1/3] fix: controller now reconciles on label changes Signed-off-by: JM Huibonhoa --- pkg/controller/mcpserver_controller.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/controller/mcpserver_controller.go b/pkg/controller/mcpserver_controller.go index 4628bb8..150c87c 100644 --- a/pkg/controller/mcpserver_controller.go +++ b/pkg/controller/mcpserver_controller.go @@ -102,7 +102,7 @@ func (r *MCPServerReconciler) Reconcile(ctx context.Context, req ctrl.Request) ( // SetupWithManager sets up the controller with the Manager. func (r *MCPServerReconciler) SetupWithManager(mgr ctrl.Manager) error { return ctrl.NewControllerManagedBy(mgr). - For(&kagentdevv1alpha1.MCPServer{}, builder.WithPredicates(predicate.GenerationChangedPredicate{})). + For(&kagentdevv1alpha1.MCPServer{}, builder.WithPredicates(predicate.GenerationChangedPredicate{}, predicate.LabelChangedPredicate{})). Owns(&appsv1.Deployment{}, builder.WithPredicates(predicate.ResourceVersionChangedPredicate{})). Owns(&corev1.Service{}, builder.WithPredicates(predicate.ResourceVersionChangedPredicate{})). Owns(&corev1.ConfigMap{}, builder.WithPredicates(predicate.ResourceVersionChangedPredicate{})). From f78f5d9e4380414e1b55f262c04eeede9d5cb9b0 Mon Sep 17 00:00:00 2001 From: JM Huibonhoa Date: Mon, 24 Nov 2025 10:02:24 -0500 Subject: [PATCH 2/3] style: fix max char length issue Signed-off-by: JM Huibonhoa --- pkg/controller/mcpserver_controller.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/controller/mcpserver_controller.go b/pkg/controller/mcpserver_controller.go index 150c87c..3acfdfa 100644 --- a/pkg/controller/mcpserver_controller.go +++ b/pkg/controller/mcpserver_controller.go @@ -102,7 +102,10 @@ func (r *MCPServerReconciler) Reconcile(ctx context.Context, req ctrl.Request) ( // SetupWithManager sets up the controller with the Manager. func (r *MCPServerReconciler) SetupWithManager(mgr ctrl.Manager) error { return ctrl.NewControllerManagedBy(mgr). - For(&kagentdevv1alpha1.MCPServer{}, builder.WithPredicates(predicate.GenerationChangedPredicate{}, predicate.LabelChangedPredicate{})). + For(&kagentdevv1alpha1.MCPServer{}, builder.WithPredicates( + predicate.GenerationChangedPredicate{}, + predicate.LabelChangedPredicate{}, + )). Owns(&appsv1.Deployment{}, builder.WithPredicates(predicate.ResourceVersionChangedPredicate{})). Owns(&corev1.Service{}, builder.WithPredicates(predicate.ResourceVersionChangedPredicate{})). Owns(&corev1.ConfigMap{}, builder.WithPredicates(predicate.ResourceVersionChangedPredicate{})). From 47b68b1739901705eafc6866efb3d3453ddb7f0d Mon Sep 17 00:00:00 2001 From: JM Huibonhoa Date: Mon, 24 Nov 2025 12:47:36 -0500 Subject: [PATCH 3/3] fix: use or predicate Signed-off-by: JM Huibonhoa --- pkg/controller/mcpserver_controller.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pkg/controller/mcpserver_controller.go b/pkg/controller/mcpserver_controller.go index 3acfdfa..c33dc80 100644 --- a/pkg/controller/mcpserver_controller.go +++ b/pkg/controller/mcpserver_controller.go @@ -103,8 +103,10 @@ func (r *MCPServerReconciler) Reconcile(ctx context.Context, req ctrl.Request) ( func (r *MCPServerReconciler) SetupWithManager(mgr ctrl.Manager) error { return ctrl.NewControllerManagedBy(mgr). For(&kagentdevv1alpha1.MCPServer{}, builder.WithPredicates( - predicate.GenerationChangedPredicate{}, - predicate.LabelChangedPredicate{}, + predicate.Or( + predicate.GenerationChangedPredicate{}, + predicate.LabelChangedPredicate{}, + ), )). Owns(&appsv1.Deployment{}, builder.WithPredicates(predicate.ResourceVersionChangedPredicate{})). Owns(&corev1.Service{}, builder.WithPredicates(predicate.ResourceVersionChangedPredicate{})).