Conversation
EItanya
reviewed
Jul 16, 2025
EItanya
left a comment
EItanya
left a comment
Contributor
There was a problem hiding this comment.
It's no longer considered a good idea to have the CRDs in a the sub-folder, we should either put them at the top-level or in a separate chart. I think I prefer separate chart so that kagent can use them as well? What do you think?
Comment on lines
+15
to
+23
| # Override the name of the chart | ||
| nameOverride: "" | ||
|
|
||
| # Override the full name of the chart | ||
| fullnameOverride: "" | ||
|
|
||
| # Target namespace for installation | ||
| # If not specified, defaults to the release namespace | ||
| namespace: "" |
Collaborator
There was a problem hiding this comment.
Is it intended that users can customize and release their own chart? Or will users just use the chart we provide to install kmcp. If its the latter, I think we can probably remove these values.
…h the version used to tag the controller image
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
jmhbh
added a commit
that referenced
this pull request
Jul 28, 2025
**Testing steps** - Download the `kmcp` cli to easily spin up a new mcp server. - Add kmcp binary location to your path `export PATH="<path_to_kmcp_bin>:$PATH"` - Run the following script in the root directory of the repository to test out the published helm chart and controller image alongside an mcp server with the echo tool. Assumes you have npx installed and your docker config is located at `~/.docker/config.json`. (demo script still wip) [kmcp.zip](https://github.com/user-attachments/files/21324828/kmcp.zip) --------- Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Co-authored-by: JM Huibonhoa <jm.huibonhoa@solo.io> Co-authored-by: Eitan Yarmush <eitan.yarmush@solo.io>
jmhbh
added a commit
that referenced
this pull request
Jul 28, 2025
**Testing steps** - Download the `kmcp` cli to easily spin up a new mcp server. - Add kmcp binary location to your path `export PATH="<path_to_kmcp_bin>:$PATH"` - Run the following script in the root directory of the repository to test out the published helm chart and controller image alongside an mcp server with the echo tool. Assumes you have npx installed and your docker config is located at `~/.docker/config.json`. (demo script still wip) [kmcp.zip](https://github.com/user-attachments/files/21324828/kmcp.zip) --------- Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Co-authored-by: JM Huibonhoa <jm.huibonhoa@solo.io> Co-authored-by: Eitan Yarmush <eitan.yarmush@solo.io> Signed-off-by: JM Huibonhoa <jm.huibonhoa@solo.io>
jmhbh
added a commit
that referenced
this pull request
Jul 28, 2025
**Testing steps** - Download the `kmcp` cli to easily spin up a new mcp server. - Add kmcp binary location to your path `export PATH="<path_to_kmcp_bin>:$PATH"` - Run the following script in the root directory of the repository to test out the published helm chart and controller image alongside an mcp server with the echo tool. Assumes you have npx installed and your docker config is located at `~/.docker/config.json`. (demo script still wip) [kmcp.zip](https://github.com/user-attachments/files/21324828/kmcp.zip) --------- Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Co-authored-by: JM Huibonhoa <jm.huibonhoa@solo.io> Co-authored-by: Eitan Yarmush <eitan.yarmush@solo.io> Signed-off-by: JM Huibonhoa <jm.huibonhoa@solo.io>
jmhbh
added a commit
that referenced
this pull request
Jul 28, 2025
**Testing steps** - Download the `kmcp` cli to easily spin up a new mcp server. - Add kmcp binary location to your path `export PATH="<path_to_kmcp_bin>:$PATH"` - Run the following script in the root directory of the repository to test out the published helm chart and controller image alongside an mcp server with the echo tool. Assumes you have npx installed and your docker config is located at `~/.docker/config.json`. (demo script still wip) [kmcp.zip](https://github.com/user-attachments/files/21324828/kmcp.zip) --------- Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io> Co-authored-by: JM Huibonhoa <jm.huibonhoa@solo.io> Co-authored-by: Eitan Yarmush <eitan.yarmush@solo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing steps
kmcpcli to easily spin up a new mcp server.export PATH="<path_to_kmcp_bin>:$PATH"~/.docker/config.json.(demo script still wip)
kmcp.zip