feat: add java init framework#75
Merged
Merged
Conversation
5ebf764 to
f5de79a
Compare
jmhbh
reviewed
Aug 29, 2025
jmhbh
left a comment
Collaborator
There was a problem hiding this comment.
This looks great, STDIO works but there seems to be some issues when deploying running the server using http
| return []string{"dist/index.js"} | ||
| case manifest.FrameworkJava: | ||
| if deployTransport == transportHTTP { | ||
| return []string{"-jar", "app.jar", "--transport", "http", "--host", "0.0.0.0", "--port", fmt.Sprintf("%d", targetPort)} |
Collaborator
There was a problem hiding this comment.
were you able to get --transport http to work? I kept running into an issue requiring a sessionId to be present.
Collaborator
There was a problem hiding this comment.
I tested with your latest changes but the /mcp endpoint was missing. I pushed a commit to fix that and its now working with the inspector so the command dist/kmcp deploy --file my-java/kmcp.yaml --transport http now works out of the box. Could you take a look at the changes and let me know if they look good to you?
c33ab72 to
19656ee
Compare
Signed-off-by: ankittk <ankit.kumar@getweave.com>
19656ee to
2243dcf
Compare
Signed-off-by: JM Huibonhoa <jm.huibonhoa@solo.io>
Signed-off-by: JM Huibonhoa <jm.huibonhoa@solo.io>
jmhbh
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #71
feat: add Java framework support for MCP server generation
Make sure you have java and maven installed locally
To test:
go test ./pkg/cli/internal/frameworks/java/...go build -o bin/kmcp ./cmd/kmcpcd test-java-project
../bin/kmcp add-tool weather --description "Get weather information"../bin/kmcp add-tool database --description "Database operations"Generate manifest
../bin/kmcp deploy --dry-run --file kmcp.yaml