Skip to content

Commit ce2405a

Browse files
committed
chart: render ate-client ServiceAccount in every mode
The JWT install overlay (manifests/ate-install/jwt) references ate-client.yaml as a top-level resource, but the chart previously guarded the SA behind {{ if eq .Values.auth.mode "jwt" }} so render-manifests.sh (mtls) never emitted it. That divergence broke verify-helm-template after merging the upstream JWT fix that added a hand-maintained manifests/ate-install/ate-client.yaml. The SA is harmless in mtls installs (unused), so render it unconditionally so the chart is the single source of truth.
1 parent 45c9967 commit ce2405a

2 files changed

Lines changed: 13 additions & 12 deletions

File tree

charts/substrate/templates/ate-client.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,10 @@ See the License for the specific language governing permissions and
1414
limitations under the License.
1515
*/}}
1616

17-
{{- if eq .Values.auth.mode "jwt" }}
1817
apiVersion: v1
1918
kind: ServiceAccount
2019
metadata:
2120
name: {{ include "substrate.fullname" (list "ate-client" .) }}
2221
namespace: {{ .Release.Namespace }}
2322
labels:
2423
apps: ate-client
25-
{{- end }}

manifests/ate-install/ate-client.yaml

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,19 @@
1-
# Copyright 2026 Google LLC
1+
# Copyright 2026 Google LLC
22
#
3-
# Licensed under the Apache License, Version 2.0 (the "License");
4-
# you may not use this file except in compliance with the License.
5-
# You may obtain a copy of the License at
3+
# Licensed under the Apache License, Version 2.0 (the "License");
4+
# you may not use this file except in compliance with the License.
5+
# You may obtain a copy of the License at
66
#
7-
# http://www.apache.org/licenses/LICENSE-2.0
7+
# http://www.apache.org/licenses/LICENSE-2.0
88
#
9-
# Unless required by applicable law or agreed to in writing, software
10-
# distributed under the License is distributed on an "AS IS" BASIS,
11-
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12-
# See the License for the specific language governing permissions and
13-
# limitations under the License.
9+
# Unless required by applicable law or agreed to in writing, software
10+
# distributed under the License is distributed on an "AS IS" BASIS,
11+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
# See the License for the specific language governing permissions and
13+
# limitations under the License.
14+
15+
# DO NOT EDIT — generated from charts/substrate by hack/render-manifests.sh.
16+
# Run `make helm-template` to regenerate.
1417

1518
apiVersion: v1
1619
kind: ServiceAccount

0 commit comments

Comments
 (0)