Skip to content

Commit ce987a5

Browse files
committed
GHA: double quote shell variables to prevent word splitting
See https://www.shellcheck.net/wiki/SC2086 In this case, it almost certainly doesn't make any difference, but it's a best practice.
1 parent cca116c commit ce987a5

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ jobs:
2424
if: github.event_name == 'push'
2525
run: |
2626
VERSION=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout)
27-
echo "version=$VERSION" >> $GITHUB_OUTPUT
28-
echo "is_snapshot=$(echo $VERSION | grep -q SNAPSHOT && echo true || echo false)" >>$GITHUB_OUTPUT
27+
echo "version=$VERSION" >> "$GITHUB_OUTPUT"
28+
echo "is_snapshot=$(echo "$VERSION" | grep -q SNAPSHOT && echo true || echo false)" >> "$GITHUB_OUTPUT"
2929
3030
- name: Configure Maven settings
3131
if: github.event_name == 'push'

0 commit comments

Comments
 (0)