Upgrade and document crate#5
Open
Mingun wants to merge 14 commits into
Open
Conversation
- byteorder: 0.5 -> 1.x - flate2: 0.2 -> 1.x
…ld be used instead Removed in kaitai-io/kaitai_struct_compiler@3fcc700
String reading reworked in kaitai-io/kaitai_struct_compiler@f0bd143 so those methods not needed anymore
|
Glad to see this get picked up! |
Member
Actually, contents of this repo have been completely replaced in #6 (because the compiler PR kaitai-io/kaitai_struct_compiler#250 for improving Rust support by @Agile86 and @revitalyr depended on another runtime library implementation, see kaitai-io/kaitai_struct#22 (comment)), so this PR is non-actionable. Someone would have to cherry-pick individual things from this PR and adapt them to the reworked implementation (and not everything may translate well or at all), if this PR has some good things worth porting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rust support still unfinished, so it is safe to not bother with backward compatibility here. I removed methods, that was newer used by the
RustCompiler/RustTranslator, add new methods which is currently recommended to be implemented by runtime and document the crate. I also add a new traitFromStrRadixthat would be used in my work on Rust target.