Skip to content

Commit 32be278

Browse files
kalbasitclaude
andcommitted
fix: address PR comments on argument parsing and README examples
- Use flag.NArg() and flag.Arg() for cleaner argument validation - Call flag.Usage() on error instead of duplicating the message - Use full package path in go tool examples for consistency Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 5fb350c commit 32be278

2 files changed

Lines changed: 7 additions & 11 deletions

File tree

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,13 +58,13 @@ At least one `--engine` flag is required; the tool exits with an error if none a
5858
SQLite + PostgreSQL only:
5959

6060
```bash
61-
go tool sqlc-multi-db --engine sqlite:sqlitedb --engine postgres:postgresdb postgresdb/querier.go
61+
go tool github.com/kalbasit/sqlc-multi-db --engine sqlite:sqlitedb --engine postgres:postgresdb postgresdb/querier.go
6262
```
6363

6464
All three engines:
6565

6666
```bash
67-
go tool sqlc-multi-db --engine sqlite:sqlitedb --engine postgres:postgresdb --engine mysql:mysqldb postgresdb/querier.go
67+
go tool github.com/kalbasit/sqlc-multi-db --engine sqlite:sqlitedb --engine postgres:postgresdb --engine mysql:mysqldb postgresdb/querier.go
6868
```
6969

7070
### go:generate
@@ -74,7 +74,7 @@ Add a `generate.go` file in your database package (e.g., `pkg/database/generate.
7474
```go
7575
package database
7676

77-
//go:generate go tool sqlc-multi-db --engine sqlite:sqlitedb --engine postgres:postgresdb postgresdb/querier.go
77+
//go:generate go tool github.com/kalbasit/sqlc-multi-db --engine sqlite:sqlitedb --engine postgres:postgresdb postgresdb/querier.go
7878
```
7979

8080
Then run:

main.go

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,16 +46,12 @@ func main() {
4646

4747
flag.Parse()
4848

49-
if len(engines) == 0 {
50-
log.Fatalf("USAGE: sqlc-multi-db --engine name:package [--engine ...] /path/to/querier.go")
49+
if len(engines) == 0 || flag.NArg() != 1 {
50+
flag.Usage()
51+
os.Exit(1)
5152
}
5253

53-
args := flag.Args()
54-
if len(args) == 0 {
55-
log.Fatalf("USAGE: sqlc-multi-db --engine name:package [--engine ...] /path/to/querier.go")
56-
}
57-
58-
querierPath := args[0]
54+
querierPath := flag.Arg(0)
5955

6056
if _, err := os.Stat(querierPath); err != nil {
6157
log.Fatalf("stat(%q): %s", querierPath, err)

0 commit comments

Comments
 (0)