Remove -lcblas and -llapack from gen_cmake_skeleton.py#4981
Open
darkdragon-001 wants to merge 1 commit into
Open
Remove -lcblas and -llapack from gen_cmake_skeleton.py#4981darkdragon-001 wants to merge 1 commit into
-lcblas and -llapack from gen_cmake_skeleton.py#4981darkdragon-001 wants to merge 1 commit into
Conversation
They are already specified for all targets via target_link_libraries() in main CMakeLists.txt. The current setup is especially problematic on systems where cblas is part of blas and therefore has to be linked via -lblas. The logic in the main CMakeLists.txt file should work correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are already specified for all targets via
target_link_libraries()in mainCMakeLists.txt. The current setup is especially problematic on systems where cblas is part of blas and therefore has to be linked via-lblas. The logic in the mainCMakeLists.txtfile should already handle this correctly.