Image asset complex field handler#203
Conversation
=> Add ezimageasset as new fieldhandler for kaliop migration bundle
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
============================================
- Coverage 67.69% 67.56% -0.14%
- Complexity 2578 2585 +7
============================================
Files 123 124 +1
Lines 6714 6730 +16
============================================
+ Hits 4545 4547 +2
- Misses 2169 2183 +14
Continue to review full report at Codecov.
|
|
Nice, thanks. |
|
I will let @mpoudevigne answer as he was the one working on this :) |
=> Add kaliop tests files
|
@gggeek Can you say me if it's ok my kaliop migration files committed ? thanks |
|
@mpoudevigne yes, migration files are committed ok. I hope to merge and release soon |
|
@gggeek thanks |
| // 2. resolve remote ids | ||
| $id = $this->contentMatcher->matchOneByKey($id)->id; | ||
|
|
||
| return new Value($id, $altText); |
There was a problem hiding this comment.
Are you sure that the $id is int? I had similar issues when using references https://github.com/ezsystems/ezplatform-ee-demo/blob/v2.5.1/src/AppBundle/Migration/FieldHandler/EzImageAsset.php#L37
is your solution works with content exporter command?
There was a problem hiding this comment.
ping @florianalexandre any answer?
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
=======================================
Coverage ? 67.56%
Complexity ? 2585
=======================================
Files ? 124
Lines ? 6730
Branches ? 0
=======================================
Hits ? 4547
Misses ? 2183
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7 participants
Add field handler for the ezplatform ezimageasset field type