feat: line_width per entity

[ildar170975]

Partly implements #555

[ZionFox]

@kalkih This would be a wonderful feature to have.

[ildar170975]

ping @akloeckner

[fran68]

I think the function getMinMaxLineWidth wouldn't meet the following use cases:

• line_width is set for entity but graph is not shown (show_graph: false). line_width is evaluated although it shouldn't
• if line_width is set per entity for all entities, the global line_width should be out of scope

Maybe you can a take a look at #e0d0323

And a question: Why is min_line_width used for x margin instead of max_line_width? Wouldn't that clip lines with higher line_width at the edge.

[ildar170975]

I think the function getMinMaxLineWidth wouldn't meet the following use cases:

* line_width is set for entity but graph is not shown (show_graph: false). line_width is evaluated although it shouldn't

* if line_width is set per entity for all entities, the global line_width should be out of scope

Maybe you can a take a look at #e0d0323

I honestly really like your idea!
fran68@e0d0323#diff-3274f1a37032fb0ae4e2823def0007c634e869ae0dfc304ff6a12c36513c3a52R13
But - I am not sure we need this getMinMaxNumber() as a separate function.
The function (abstract from a particular option) takes an arr_obj array of objects (dicts), and either uses a "local" item[opt] option value or a "global" option value.
Great, but probably the line_width case could be the ONLY case where this function is needed as a separate function.

Meanwhile, I added a few lines to implement your cases "show_graph: false" & "every entity has line_width" - took your code as an inspiration.
Please check the added commit (do not bother about linter errors, they are unrelated & fixed in the next commit).
May be a bit more cumbersome than your separate function though...

[ildar170975]

And a question: Why is min_line_width used for x margin instead of max_line_width? Wouldn't that clip lines with higher line_width at the edge with higher line_width.

Need to check once again...

Update:
Since it was decided some time ago, could not recall a reason.
But now I recall: the reason was that I did not like a horizontal spacing between an Y-axis and a curve.
Compare this:

margin[X] = min, margin[Y] = max:

margin[X] = max, margin[Y] = max - see a horizontal gap:

So, I chose the 1st variant.

[ildar170975]

@fran68
Also, (might want to test in your setup), no need to calculate min & max values for bars.
8105211

[fran68]

@fran68 Also, (might want to test in your setup), no need to calculate min & max values for bars. 8105211

Wouldn't it be better to place it in the filter?

[fran68]

Thanks for explanation!

However, isn't the design approach to have a line which has round shapes at the ends and does not touch the edge of the diagram when fill is set to false?

I would prefer the max option, maybe by extending the lines. Or we handle it in the way when the fill is set to true/fade, no gap at all!?

[ildar170975]

Wouldn't it be better to place it in the filter?

Probably better, cannot say, away from a PC, will be able to check in a week I hope.

[ildar170975]

Thanks for explanation!

Sorry, cannot answer now. For these kind of questions , I need a PC nearby (((
Just a quick reply: we may start with the proposed algorithm, and then start playing, then improve if needed.