CreateAccountUseCaseImpl: do not generate unrelated new private keys

Author: s373r

src/domain/accounts/services/src/use_cases/create_account_use_case_impl.rs

@@ -108,7 +108,7 @@ impl CreateAccountUseCaseImpl {
         Ok(())
     }
 
-    async fn save_private_key(
+    async fn maybe_save_private_key(
         &self,
         account_id: &odf::AccountID,
         key: odf::metadata::SigningKey,
@@ -161,10 +161,6 @@ impl CreateAccountUseCase for CreateAccountUseCaseImpl {
     ) -> Result<Account, CreateAccountError> {
         self.save_account(account, password).await?;
 
-        // Generate a new private key.
-        let (private_key, _) = odf::AccountID::new_generated_ed25519();
-        self.save_private_key(&account.id, private_key).await?;
-
         if !quiet {
             self.notify_account_created(account).await?;
         }
@@ -205,7 +201,8 @@ impl CreateAccountUseCase for CreateAccountUseCaseImpl {
         };
 
         self.save_account(&account, &password).await?;
-        self.save_private_key(&account.id, account_key).await?;
+        self.maybe_save_private_key(&account.id, account_key)
+            .await?;
 
         self.notify_account_created(&account).await?;
 

src/domain/signing/services/tests/tests/test_sign_eip712_use_case_impl.rs

@@ -69,8 +69,6 @@ const ADMIN: &str = "admin";
 
 #[test]
 fn test_has_access_by_name_matrix() {
-    let f = SignEip712UseCaseImpl::has_access_by_account_name;
-
     for (subject_account_name, target_account_name, expected) in [
         // molecule
         (MOLECULE, MOLECULE, true),
@@ -87,7 +85,10 @@ fn test_has_access_by_name_matrix() {
         (MOLECULE_DEV, "molecule.devops", false),
         (MOLECULE_DEV, "molecule.dev.probe8503325863", true),
     ] {
-        let actual = f(subject_account_name, target_account_name);
+        let actual = SignEip712UseCaseImpl::has_access_by_account_name(
+            subject_account_name,
+            target_account_name,
+        );
 
         assert_eq!(
             expected, actual,
@@ -647,7 +648,6 @@ impl SignEip712UseCaseHarness {
                 [5; _],
             ),
             // Accounts
-            // NOTE: for InMemoryDidSecretKeyRepository we rewrite keys with pregenerated values
             (
                 DidEntity::new_account(molecule_account_id().to_string()),
                 [6; _],