Kamu UI 842 refactoring#856
Merged
dmitriy-borzenko merged 66 commits intoJul 13, 2026
Merged
Conversation
…sts pass, lint fails with 4 planned fixes)
Fix A — type-switch destroys nested config Fix B — dangling blank row when editing while adding Fix C - trackBy identity (use idx instead of name)
added 11 commits
July 2, 2026 20:10
dmitriy-borzenko
merged commit Jul 13, 2026
92c5332
into
kamu-ui-842-Editing-the-ODF-schema-in-sources
1 check passed
dmitriy-borzenko
added a commit
that referenced
this pull request
Jul 13, 2026
* added EditSchemaTableComponent * added a few cheks for name * fixed UI comments * edit Struct type for first level * Kamu UI 842 refactoring (#856) * Fixed obvious linting issues * Added schema normalization helpers + stabilized the quality gates (tests pass, lint fails with 4 planned fixes) * Recursive validator + warning helpers * Ran Prettier * Prettier hook for Claude Code * `EditSchemaTableComponent` → pure recursive component * Remove the singleton; rewire `SchemaFieldComponent` to a typed`FormControl` * Serialization: build YAML from the form value (polling + push) * Load path: read schema via GQL structured event in ODF format (polling + push) * Wire validation + warnings into the UI * Removed some legacy code * Separated fragments for encoded view of blocks and schema fields access * Removed redundand casts * Tests: revise the `data-test-id` scheme * Tests: harness hierarchy * Tests: main component test suites using harnesses * Test cleanups * Tests: Serialization & load * Tests: First integration-level editing suite * Tests: new schema for testing + harness extensions * Tests: extended test suites with new cases * Bug fixes + specs asserting the corrected behavior Fix A — type-switch destroys nested config Fix B — dangling blank row when editing while adding Fix C - trackBy identity (use idx instead of name) * Handling keyboard events in the editor * Sketch for re-ordering fields via drag & drop * Code review bug fixes * More code review fixes * More code review corrections * Bug fixes from visual testing * Prettier ran * "Add Field" button on cover only * CSS improvements, nested tables fitting better, "Add Field" button hides when not hovering * fixed console errors and unite tests warnings * changed tooltips text * fixed css style for nested dropdown * changed paddings * added font-monospace class for cells * set the maximum text length for table cells * added checkbox for Optional type * fixed types control length * Added saving of the line being edited when switching to another line * removed pattern validation * fixed prettier warning * fixed the length for the base-type control * replaced the optional checkbox with a toggle * minor changes * added unit tests * minor changes * extended condition for 'Add field' button * fixed css styles * handled the case involving the parent drag * moved 'drag_indicator' icon * fixed an issue with saving the external structure * fixed id for JsonKindFieldComponent * added localEditingCoordinator * fixed bug with deletion * code improvement * deleted a row with an empty name when clicking the edit icon * added warning icon for empty struct * Removed old schema editing component * Minor issues fixed * Safer schema updates in service * removed schema name pattern * optimization of error and warning calculations * removed the union for the ket schema * fixed linter warning * modified datasetBlocksEncodedByEventType request --------- Co-authored-by: dmitriy-borzenko <dmytro.borzenko@kamu.dev> * changed CHANGELOG.md --------- Co-authored-by: dmitriy-borzenko <dmytro.borzenko@kamu.dev> Co-authored-by: Sergei Zaychenko <szaychenko@kamu.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #842