Fix: Remove sticky styles out of Spelunker management (First aid)#76
Open
KSR-Yasuda wants to merge 1 commit into
Open
Fix: Remove sticky styles out of Spelunker management (First aid)#76KSR-Yasuda wants to merge 1 commit into
KSR-Yasuda wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes spell check styles unexpectedly remains.
Spelunker manages
match()styles inb:match_id_dict, though,somehow there happens to miss some styles unmanaged, probably.
For first aid,
removes the spellcheck
match()styles ofg:spelunker_spell_bad_groupandg:spelunker_complex_or_compound_word_groupon clearing spellcheck matches
(Match groups
SpelunkerSpellBadandSpelunkerComplexOrCompoundWord, by default).As a side effect,
it also removes your custom
match()settings, if the matchgroupare them.Although, generally users uses Spelunker-very-own styles, aren't they?
時々、スペルチェックのスタイルが 意図せず 残ること があります。
Spelunker は
match()のスタイルをb:match_id_dict変数 で管理していますが、なぜか、いくつかのスタイルが 管理されずに 取り残されること があるようです。
応急処置として:
スペルチェックの
match()スタイルg:spelunker_spell_bad_groupとg:spelunker_complex_or_compound_word_groupを、スペルチェックのマッチ箇所のクリア のタイミングで 削除するようにしました
(デフォルトでは、マッチグループ
SpelunkerSpellBadとSpelunkerComplexOrCompoundWord).副作用として:
ユーザが自分で指定した
match()設定 についても、groupが これらに当てはまる場合は、削除します。でも 大抵、ユーザは Spelunker専用に スタイルを作って 使うか と思うので、あまり 問題にならないと思っています。