Skip to content

Commit 52f4a4a

Browse files
committed
Remove unnecessary uses of FakeX509ExtendedTrustManager
1 parent 2d8844c commit 52f4a4a

File tree

1 file changed

+18
-9
lines changed

1 file changed

+18
-9
lines changed

okhttp/src/test/java/io/grpc/okhttp/TlsTest.java

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -123,10 +123,13 @@ public void perRpcAuthorityOverride_hostnameVerification_success()
123123
.keyManager(serverCert, serverPrivateKey)
124124
.build();
125125
}
126+
ChannelCredentials channelCreds;
127+
try (InputStream caCert = TlsTesting.loadCert("ca.pem")) {
128+
channelCreds = TlsChannelCredentials.newBuilder()
129+
.trustManager(caCert)
130+
.build();
131+
}
126132
Server server = grpcCleanupRule.register(server(serverCreds));
127-
ChannelCredentials channelCreds = TlsChannelCredentials.newBuilder()
128-
.trustManager(getFakeX509ExtendedTrustManager())
129-
.build();
130133
ManagedChannel channel = grpcCleanupRule.register(clientChannel(server, channelCreds));
131134

132135
ClientCalls.blockingUnaryCall(channel, SimpleServiceGrpc.getUnaryRpcMethod(),
@@ -149,10 +152,13 @@ public void perRpcAuthorityOverride_hostnameVerification_failure_rpcFails()
149152
.keyManager(serverCert, serverPrivateKey)
150153
.build();
151154
}
155+
ChannelCredentials channelCreds;
156+
try (InputStream caCert = TlsTesting.loadCert("ca.pem")) {
157+
channelCreds = TlsChannelCredentials.newBuilder()
158+
.trustManager(caCert)
159+
.build();
160+
}
152161
Server server = grpcCleanupRule.register(server(serverCreds));
153-
ChannelCredentials channelCreds = TlsChannelCredentials.newBuilder()
154-
.trustManager(getFakeX509ExtendedTrustManager())
155-
.build();
156162
ManagedChannel channel = grpcCleanupRule.register(clientChannel(server, channelCreds));
157163

158164
try {
@@ -180,10 +186,13 @@ public void perRpcAuthorityOverride_hostnameVerification_failure_flagDisabled_rp
180186
.keyManager(serverCert, serverPrivateKey)
181187
.build();
182188
}
189+
ChannelCredentials channelCreds;
190+
try (InputStream caCert = TlsTesting.loadCert("ca.pem")) {
191+
channelCreds = TlsChannelCredentials.newBuilder()
192+
.trustManager(caCert)
193+
.build();
194+
}
183195
Server server = grpcCleanupRule.register(server(serverCreds));
184-
ChannelCredentials channelCreds = TlsChannelCredentials.newBuilder()
185-
.trustManager(getFakeX509ExtendedTrustManager())
186-
.build();
187196
ManagedChannel channel = grpcCleanupRule.register(clientChannel(server, channelCreds));
188197

189198
ClientCalls.blockingUnaryCall(channel, SimpleServiceGrpc.getUnaryRpcMethod(),

0 commit comments

Comments
 (0)