Skip to content

Commit 11cb238

Browse files
committed
Automatically run MCS connection scaling interop tests if Java server is in the args, without needing separate flag for it.
1 parent 82bef3f commit 11cb238

2 files changed

Lines changed: 2 additions & 19 deletions

File tree

tools/internal_ci/linux/grpc_interop_tocloud.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,5 @@ action {
2626

2727
env_vars {
2828
key: "RUN_TESTS_FLAGS"
29-
value: "-l all -s all --use_docker --http2_interop --max_concurrent_streams_connection_scaling -t -j 8 --bq_result_table interop_results --verbose"
29+
value: "-l all -s all --use_docker --http2_interop -t -j 8 --bq_result_table interop_results"
3030
}

tools/run_tests/run_interop_tests.py

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1435,14 +1435,6 @@ def aggregate_http2_results(stdout):
14351435
nargs="?",
14361436
help="Upload test results to a specified BQ table.",
14371437
)
1438-
argp.add_argument(
1439-
"--max_concurrent_streams_connection_scaling",
1440-
default=False,
1441-
action="store_const",
1442-
const=True,
1443-
help="Enable Max concurrent streams connection scaling testing",
1444-
)
1445-
14461438
args = argp.parse_args()
14471439

14481440
servers = set(
@@ -1480,13 +1472,6 @@ def aggregate_http2_results(stdout):
14801472
)
14811473
sys.exit(1)
14821474

1483-
if args.max_concurrent_streams_connection_scaling and not args.use_docker:
1484-
print(
1485-
"Running interop for max concurrent streams connection scaling is only supported with --use_docker option"
1486-
" enabled."
1487-
)
1488-
sys.exit(1)
1489-
14901475
# we want to include everything but objc in 'all'
14911476
# because objc won't run on non-mac platforms
14921477
all_but_objc = set(_LANGUAGES) - set(["objc"])
@@ -1818,7 +1803,7 @@ def aggregate_http2_results(stdout):
18181803
)
18191804
jobs.append(test_job)
18201805

1821-
if args.max_concurrent_streams_connection_scaling:
1806+
if 'java' in servers:
18221807
languages_for_mcs_cs = set(
18231808
_LANGUAGES[l]
18241809
for l in _LANGUAGES_WITH_HTTP2_CLIENTS_FOR_HTTP2_SERVER_TEST_CASES
@@ -1827,8 +1812,6 @@ def aggregate_http2_results(stdout):
18271812
if not languages_for_mcs_cs:
18281813
print('MCS connection scaling tests will be skipped since none of the supported client languages for MCS connection scaling testcases was specified')
18291814
else:
1830-
if args.server != 'java':
1831-
print('Using java for MCS connection scaling server to be used by all MCS connection scaling clients.')
18321815
mcs_server_jobspec = server_jobspec(
18331816
_LANGUAGES['java'],
18341817
docker_images.get('java'),

0 commit comments

Comments
 (0)