Draft
Conversation
# Conflicts: # InertiaCore/Extensions/Configure.cs # InertiaCore/Response.cs # InertiaCore/Utils/LocationResult.cs
Draft
# Conflicts: # InertiaCore/Extensions/Configure.cs # InertiaCore/Extensions/InertiaExtensions.cs # InertiaCore/Response.cs # InertiaCore/ResponseFactory.cs # InertiaCore/Utils/AlwaysProp.cs # InertiaCore/Utils/LocationResult.cs # InertiaCoreTests/UnitTestAlwaysData.cs
# Conflicts: # InertiaCore/Extensions/Configure.cs # InertiaCore/Extensions/InertiaExtensions.cs # InertiaCore/Inertia.cs # InertiaCore/Response.cs # InertiaCore/ResponseFactory.cs # InertiaCore/Utils/AlwaysProp.cs # InertiaCore/Utils/LocationResult.cs # InertiaCoreTests/UnitTestAlwaysData.cs
# Conflicts: # InertiaCore/Props/LazyProp.cs # InertiaCore/Response.cs
# Conflicts: # InertiaCore/Response.cs
# Conflicts: # .github/workflows/dotnet.yml # InertiaCore/Response.cs # InertiaCore/ResponseFactory.cs
# Conflicts: # .github/workflows/dotnet.yml # InertiaCore/Extensions/InertiaExtensions.cs # InertiaCore/Inertia.cs # InertiaCore/Response.cs # InertiaCore/ResponseFactory.cs
# Conflicts: # InertiaCore/Models/Page.cs # InertiaCore/ResponseFactory.cs
Mirror the canonical Inertia Laravel adapter's merge prop resolution so the wire format and filtering semantics stay in sync with the Inertia.js frontend contract. - Extend Mergeable with Append/AppendsAtPaths/PrependsAtPaths plus AppendAt/PrependAt/Prepend helpers and AppendsAtRoot/PrependsAtRoot predicates for directional merging at nested paths. - Add PrependProps to the Page model and change MatchPropsOn from Dictionary<string, string[]> to a flat List<string> of "key.strategy" entries, matching Laravel's resolveMergeMatchingKeys output. - Add GetMergeablePropsForRequest in Response that filters _props by Mergeable + ShouldMerge, then rejects Reset keys and applies Partial-Only / Partial-Except in one pass. All four Resolve methods operate on that pre-filtered collection, removing the duplicated header parsing that previously lived in each method. - Cover the Reset-header interaction with a new test that asserts a prop listed in X-Inertia-Reset is excluded from mergeProps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://inertiajs.com/merging-props
To be merged after #19, #20 and #22